[v1.18] lb: Implement Hybrid-DSR via annotation infrastructure#43056
Merged
julianwiedmann merged 1 commit intov1.18from Dec 2, 2025
Merged
[v1.18] lb: Implement Hybrid-DSR via annotation infrastructure#43056julianwiedmann merged 1 commit intov1.18from
julianwiedmann merged 1 commit intov1.18from
Conversation
Member
Author
|
/test |
[ upstream commit 0360502 ] [ backporter's notes: remove wildcard entries in the test, they don't exist on v1.18. ] Re-implement Hybrid-DSR mode to use the same flag-based mechanism as annotation mode, eliminating duplicate datapath logic. Changes: - Update ToSVCForwardingMode() to accept optional protocol parameter - For LBModeHybrid, return DSR mode for TCP (proto 6), SNAT otherwise - Pass protocol to ToSVCForwardingMode() in BPF reconciler - Add tests to demonstrate that we're producing the expected frontend entries. This allows the control plane to set SVC_FLAG_FWD_MODE_DSR on a per-frontend basis for TCP services in Hybrid mode, while the datapath uses the same flag-checking logic for all selective DSR modes. Signed-off-by: saiaunghlyanhtet <saiaunghlyanhtet2003@gmail.com> Signed-off-by: Julian Wiedmann <jwi@isovalent.com>
b3b8c51 to
7b01450
Compare
Member
Author
|
/test |
saiaunghlyanhtet
approved these changes
Dec 1, 2025
dylandreimerink
approved these changes
Dec 2, 2025
This was referenced Mar 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To ensure smooth upgrades to
v1.19, this picks up the controlplane change from #42788. This way all service map entries have a validDSR yes/noflag, and the datapath can trust the flag whenever thev1.19programs start to roll out.