Skip to content

k8s: remove permissions for endpoints#42760

Merged
marseel merged 1 commit intomainfrom
pr/marseel/clean_endpoints
Jan 15, 2026
Merged

k8s: remove permissions for endpoints#42760
marseel merged 1 commit intomainfrom
pr/marseel/clean_endpoints

Conversation

@marseel
Copy link
Copy Markdown
Member

@marseel marseel commented Nov 13, 2025

With deprecation of Endpoints in 1.33 k8s, we should also remove permission so we don't accidentally start using it again.

Related: #41083
Related: #40555

k8s: remove permissions for list/get/watch of endpoints

@marseel marseel added the release-note/minor This PR changes functionality that users may find relevant to operating Cilium. label Nov 13, 2025
@marseel marseel force-pushed the pr/marseel/clean_endpoints branch from b89fa59 to 3fdb8f1 Compare November 13, 2025 13:27
@marseel
Copy link
Copy Markdown
Member Author

marseel commented Nov 13, 2025

/test

@marseel marseel mentioned this pull request Nov 13, 2025
Open
@odinuge
Copy link
Copy Markdown
Member

odinuge commented Nov 13, 2025

Should we keep this until the next release of cilium given it seems like there was still usage in v1.18, so that we avoid breaking potential usage during an upgrade?

@marseel
Copy link
Copy Markdown
Member Author

marseel commented Nov 13, 2025 •
edited
Loading

That was mostly a test to check if everything works and it failed, FYI: #39105 (comment)

@marseel
Copy link
Copy Markdown
Member Author

marseel commented Nov 13, 2025

But yea, once we know that everything works without that permission, we should remove it in +1 version.

@marseel marseel added the dont-merge/wait-until-release Freeze window for current release is blocking non-bugfix PRs label Nov 13, 2025
@marseel marseel force-pushed the pr/marseel/clean_endpoints branch from 3fdb8f1 to a669df4 Compare November 20, 2025 11:09
@marseel
Copy link
Copy Markdown
Member Author

marseel commented Nov 20, 2025

/test

@marseel marseel force-pushed the pr/marseel/clean_endpoints branch from a669df4 to b58c195 Compare December 10, 2025 14:28
@github-actions
Copy link
Copy Markdown

github-actions bot commented Jan 10, 2026

This pull request has been automatically marked as stale because it
has not had recent activity. It will be closed if no further activity
occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale The stale bot thinks this issue is old. Add "pinned" label to prevent this from becoming stale. label Jan 10, 2026
@marseel
k8s: remove permissions for endpoints
03659a2 
With deprecation of Endpoints in 1.33 k8s, we should also remove
permission so we don't accidentally start using it again.

Related: #41083
Related: #40555

Signed-off-by: Marcel Zieba <marcel.zieba@isovalent.com>
@marseel marseel force-pushed the pr/marseel/clean_endpoints branch from b58c195 to 03659a2 Compare January 12, 2026 11:58
@marseel
Copy link
Copy Markdown
Member Author

marseel commented Jan 12, 2026

/test

@github-actions github-actions bot removed the stale The stale bot thinks this issue is old. Add "pinned" label to prevent this from becoming stale. label Jan 13, 2026
@aanm aanm removed the dont-merge/wait-until-release Freeze window for current release is blocking non-bugfix PRs label Jan 14, 2026
@marseel marseel marked this pull request as ready for review January 15, 2026 10:34
@marseel marseel requested a review from a team as a code owner January 15, 2026 10:34
@marseel marseel requested a review from gandro January 15, 2026 10:34
gandro
gandro approved these changes Jan 15, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@gandro gandro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Jan 15, 2026
@marseel marseel added this pull request to the merge queue Jan 15, 2026
Merged via the queue into main with commit f0ff8eb Jan 15, 2026
355 checks passed
@marseel marseel deleted the pr/marseel/clean_endpoints branch January 15, 2026 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gandro gandro gandro approved these changes

Assignees

No one assigned

Labels

ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/minor This PR changes functionality that users may find relevant to operating Cilium.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@marseel @odinuge @gandro @msune @aanm