helm: clustermesh: deprecate passing tls cert/keys in values#42576
Merged
giorio94 merged 3 commits intocilium:mainfrom Nov 14, 2025
Merged
helm: clustermesh: deprecate passing tls cert/keys in values#42576giorio94 merged 3 commits intocilium:mainfrom
giorio94 merged 3 commits intocilium:mainfrom
Conversation
Member
Author
|
/test |
1286689 to
a260438
Compare
Member
Author
|
/test |
squeed
approved these changes
Nov 4, 2025
giorio94
reviewed
Nov 5, 2025
Member
giorio94
left a comment
There was a problem hiding this comment.
Thanks a lot for taking care of this 🚀 I've left a few comments inline, mostly suggestions while you are touching these bits.
de609b9 to
3fa1865
Compare
Member
Author
|
/test |
This cert is no longer used and was still present in Helm. Signed-off-by: Arthur Outhenin-Chalandre <git@mrfreezeex.fr>
3fa1865 to
41964ff
Compare
Member
Author
|
/test |
Member
Author
|
/test |
giorio94
reviewed
Nov 11, 2025
Member
giorio94
left a comment
There was a problem hiding this comment.
Thanks! A few comments inline.
adafadd to
c3495a0
Compare
Member
Author
|
/test |
c3495a0 to
e417231
Compare
Member
Author
|
/test |
giorio94
approved these changes
Nov 14, 2025
Member
giorio94
left a comment
There was a problem hiding this comment.
Thanks! Just a couple of final nits inline.
e417231 to
6c0f5fb
Compare
Member
Author
|
/test |
Signed-off-by: Arthur Outhenin-Chalandre <git@mrfreezeex.fr>
6c0f5fb to
81a6489
Compare
Member
Author
|
/test |
Signed-off-by: Arthur Outhenin-Chalandre <git@mrfreezeex.fr>
81a6489 to
d01ae5a
Compare
Member
Author
|
/test |
This was referenced Nov 16, 2025
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is mainly to match hubble deprecating cert passing in values.
Also slightly clarify that disabling the config could be used to generate the clustermesh secrets as some users are already doing (for instance this issue #42330 mentions a setup using External Secret Operator).