fix(ctmap/gc): fix race conditions and flakiness in TestGCEnableRatchet#42009
Merged
tommyp1ckles merged 2 commits intocilium:mainfrom Dec 2, 2025
Merged
fix(ctmap/gc): fix race conditions and flakiness in TestGCEnableRatchet#42009tommyp1ckles merged 2 commits intocilium:mainfrom
tommyp1ckles merged 2 commits intocilium:mainfrom
Conversation
df729ba to
5e72324
Compare
tommyp1ckles
requested changes
Oct 15, 2025
Contributor
tommyp1ckles
left a comment
There was a problem hiding this comment.
Nice work, thanks for fixing this up @AritraDey-Dev 😄
Just had one comment regarding how we deal with mutating the global config vars.
a6e5402 to
91a62fb
Compare
tommyp1ckles
requested changes
Oct 22, 2025
|
This pull request has been automatically marked as stale because it |
37fbc71 to
a644323
Compare
tommyp1ckles
approved these changes
Dec 2, 2025
Contributor
|
/test |
Contributor
|
@AritraDey-Dev Thanks for the changes! I see some unrelated test failures; could you do a rebase on this branch? |
tommyp1ckles
requested changes
Dec 2, 2025
a644323 to
6323366
Compare
Signed-off-by: Aritra Dey <adey01027@gmail.com>
Signed-off-by: Aritra Dey <adey01027@gmail.com>
6323366 to
8631317
Compare
Member
Author
|
/test |
tommyp1ckles
approved these changes
Dec 2, 2025
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix race conditions and flakiness in
TestGCEnableRatchetPlease ensure your pull request adheres to the following guidelines:
description and a
Fixes: #XXXline if the commit addresses a particularGitHub issue.
Fixes: <commit-id>tag, thenplease add the commit author[s] as reviewer[s] to this issue.
Fixes: #41960