Skip to content

ipam/multipool: respect ipam-cilium-node-update-rate for CiliumNode updates#41447

Merged
pippolo84 merged 1 commit intocilium:mainfrom
asdfmi:pr/ipam-multipool-respect-node-update-rate
Sep 17, 2025
Merged

ipam/multipool: respect ipam-cilium-node-update-rate for CiliumNode updates#41447
pippolo84 merged 1 commit intocilium:mainfrom
asdfmi:pr/ipam-multipool-respect-node-update-rate

Conversation

@asdfmi
Copy link
Copy Markdown
Contributor

@asdfmi asdfmi commented Aug 31, 2025 •
edited
Loading

Replace hardcoded 15s trigger MinInterval with conf.IPAMCiliumNodeUpdateRate in multi-pool IPAM.

IPAM (MultiPool): Honor ipam-cilium-node-update-rate for CiliumNode updates (was hardcoded to 15s by default). Default remains 15s.

@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Aug 31, 2025
@github-actions github-actions bot added the kind/community-contribution This was a contribution made by a community member. label Aug 31, 2025
@asdfmi asdfmi force-pushed the pr/ipam-multipool-respect-node-update-rate branch from 867a113 to bac3161 Compare August 31, 2025 11:08
@asdfmi
ipam/multipool: respect ipam-cilium-node-update-rate for CiliumNode u…
042a32f 
…pdates

Signed-off-by: asdfmi <nattogohan710580@gmail.com>
@asdfmi asdfmi force-pushed the pr/ipam-multipool-respect-node-update-rate branch from bac3161 to 042a32f Compare September 2, 2025 14:34
@asdfmi asdfmi marked this pull request as ready for review September 2, 2025 14:44
@asdfmi asdfmi requested a review from a team as a code owner September 2, 2025 14:44
@asdfmi asdfmi requested a review from pippolo84 September 2, 2025 14:44
@ldelossa ldelossa added the area/ipam IP address management, including cloud IPAM label Sep 2, 2025
@ldelossa
Copy link
Copy Markdown
Contributor

ldelossa commented Sep 2, 2025

/test

@ldelossa ldelossa added the release-note/bug This PR fixes an issue in a previous release of Cilium. label Sep 2, 2025
pippolo84
pippolo84 approved these changes Sep 2, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@pippolo84 pippolo84 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@asdfmi
Copy link
Copy Markdown
Contributor Author

asdfmi commented Sep 4, 2025

flake?

https://github.com/cilium/cilium/actions/runs/17407386426/job/49415444821
https://github.com/cilium/cilium/actions/runs/17406891343/job/49415383493?pr=41447

@pippolo84 pippolo84 mentioned this pull request Sep 4, 2025
Closed
@pippolo84
Copy link
Copy Markdown
Member

pippolo84 commented Sep 4, 2025

ci-e2e-upgrade flake tracked here, rerunning

@pippolo84 pippolo84 removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Sep 17, 2025
@pippolo84 pippolo84 added this pull request to the merge queue Sep 17, 2025
Merged via the queue into cilium:main with commit 11fecab Sep 17, 2025
71 of 72 checks passed
@maintainer-s-little-helper maintainer-s-little-helper bot added ready-to-merge This PR has passed all tests and received consensus from code owners to merge. labels Sep 17, 2025
@cilium-release-bot cilium-release-bot bot moved this to Released in cilium v1.19.0 Feb 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pippolo84 pippolo84 pippolo84 approved these changes

Assignees

No one assigned

Labels

area/ipam IP address management, including cloud IPAM kind/community-contribution This was a contribution made by a community member. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/bug This PR fixes an issue in a previous release of Cilium.

Projects

No open projects
cilium v1.19.0
Status: Released

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@asdfmi @ldelossa @pippolo84