gha: run checkpatch check only on PR events#41308
Merged
Conversation
Previously, the checkpatch script used to internally skip the checks when not targeting the main branch. The blamed commit bumped it to a more zealous version that runs against all target branches, and explicitly fails in case any internal command fails. However, this check is now failing both on push and merge queue events, as the GITHUB_REF does not point to a PR. Let's prevent this by making it run on PR events only, to restore the previous behavior in this case. There's not much point in running checkpatch on already merged commits anyways; similarly, no reason for running it as part of the merge queue, given that the check is not required, and the result does not depend on whether the branch is rebased. Fixes: 4a33221 ("checkpatch: bump checkpatch version, and minor adaptations") Signed-off-by: Marco Iorio <marco.iorio@isovalent.com>
Member
Author
|
/test |
Artyop
reviewed
Aug 21, 2025
17 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, the checkpatch script used to internally skip the checks when not targeting the main branch. The blamed commit bumped it to a more zealous version that runs against all target branches, and explicitly fails in case any internal command fails.
However, this check is now failing both on push and merge queue events, as the GITHUB_REF does not point to a PR. Let's prevent this by making it run on PR events only, to restore the previous behavior in this case. There's not much point in running checkpatch on already merged commits anyways; similarly, no reason for running it as part of the merge queue, given that the check is not required, and the result does not depend on whether the branch is rebased.
Fixes: 4a33221 ("checkpatch: bump checkpatch version, and minor adaptations")