Helm: Ensure consistent default labels for all ServiceMonitor resources#41240
Merged
gandro merged 1 commit intocilium:mainfrom Aug 19, 2025
Merged
Conversation
|
Commit 772385e does not match "(?m)^Signed-off-by:". Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin |
Member
|
Please sign-off your commit by using |
772385e to
696bff5
Compare
Contributor
Author
|
@gandro Whoops, sorry! Fixed! :) |
Member
|
/test |
marseel
approved these changes
Aug 18, 2025
Member
|
I've restarted ci-ginko because it fails because of #41194. If it keeps failing we might have to rebase on main to fix it. |
This also fixes an issue were `labels=null` for the hubble-relay has been configured by default which lead to permanent Out-of-Sync state in Argo-CD Signed-off-by: Matthias Baur <m.baur@syseleven.de>
auto-merge was automatically disabled
August 19, 2025 08:23
Head branch was pushed to by a user without write access
696bff5 to
a2e5702
Compare
Member
|
/test |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This also fixes an issue were
labels=nullfor the hubble-relay has been configured by default which lead to permanent Out-of-Sync state in Argo-CDPlease ensure your pull request adheres to the following guidelines:
description and a
Fixes: #XXXline if the commit addresses a particularGitHub issue.
Fixes: <commit-id>tag, thenplease add the commit author[s] as reviewer[s] to this issue.
Fixes: #issue-number