bpf: add support for delinearized ARP packets#41233
Merged
pchaigno merged 1 commit intocilium:mainfrom Aug 22, 2025
Merged
Conversation
ec954f1 to
b494553
Compare
c478ebb to
71a810a
Compare
3 tasks
Internal ARP-handling functions such as those in lib/arp.h expect linearized ARP packets. However, no code exist to linearize this packet type. This means user-facing features such as L2 Announcements break easily if the kernel decides to split ARP request in chunks. Implement revalidate_data_arp_pull() and call it the same way it is done for IPv4/IPv6 packets to prevent this from happening and keep things consistent across protocols. Fixes: cilium#40419 Signed-off-by: Valentine Sinitsyn <valentine.sinitsyn@gmail.com>
71a810a to
de41466
Compare
Member
|
/test |
Contributor
|
This makes sense to me. Ideally I'd like to have confirmation in #40419 that this fixes the issue first before merging. |
Author
jrife
approved these changes
Aug 21, 2025
17 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Internal ARP-handling functions such as those in lib/arp.h expect linearized ARP packets. However, no code exist to linearize this packet type. This means user-facing features such as L2 Announcements break easily if the kernel decides to split ARP request in chunks.
Implement revalidate_data_arp_pull() and call it the same way it is done for IPv4/IPv6 packets to prevent this from happening and keep things consistent across protocols.
Fixes: #40419
Signed-off-by: Valentine Sinitsyn valentine.sinitsyn@gmail.com