pkg/ipam: fix nil dereference during pool shrink operation#41198
Merged
aditighag merged 1 commit intocilium:mainfrom Aug 19, 2025
Merged
pkg/ipam: fix nil dereference during pool shrink operation#41198aditighag merged 1 commit intocilium:mainfrom
aditighag merged 1 commit intocilium:mainfrom
Conversation
When shrinking a CiliumPodIPPool the operator could crash with a nil pointer dereference in updateCIDRSets. The loop deletes entries from the slice it is iterating over, leaving behind nil slots that are dereferenced in the next iteration. This change skips over nil items in the slice. Signed-off-by: alimehrabikoshki <79400736+alimehrabikoshki@users.noreply.github.com>
e5b2e57 to
2e7b9fa
Compare
Member
|
/test |
17 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please ensure your pull request adheres to the following guidelines:
description and a
Fixes: #XXXline if the commit addresses a particularGitHub issue.
Fixes: <commit-id>tag, thenplease add the commit author[s] as reviewer[s] to this issue.
When shrinking a CiliumPodIPPool the operator could crash with a nil pointer dereference in updateCIDRSets. The loop deletes entries from the slice it is iterating over, leaving behind nil slots that are dereferenced in the next iteration. This change skips over nil items in the slice. It also introduces a new unit test for this behaviour.
Fixes: #41197