xds: optimize log message of waiting for proxy update#41190
Merged
sayboras merged 1 commit intocilium:mainfrom Aug 22, 2025
Merged
xds: optimize log message of waiting for proxy update#41190sayboras merged 1 commit intocilium:mainfrom
sayboras merged 1 commit intocilium:mainfrom
Conversation
Member
Author
|
/test |
Currently, the log message that indcates the end of waiting for proxy updates always contains the log field `error`, even if there wasn't any error. ``` [...] msg="UpdateEnvoyResources: Finished waiting for proxy updates" error=<nil> ``` This commit optimzes this by adding the error log field conditionally. Signed-off-by: Marco Hofstetter <marco.hofstetter@isovalent.com>
b2eb9ba to
14b7b91
Compare
Member
Author
|
rebased to |
Member
Author
|
/test |
sayboras
approved these changes
Aug 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the log message that indcates the end of waiting for proxy updates always contains the log field
error, even if there wasn't any error.This commit optimzes this by adding the error log field conditionally.