neighbor: Fix bug where neighbor discovery subsystem reports unhealthy when it is healthy#41186
Merged
joestringer merged 1 commit intocilium:mainfrom Aug 19, 2025
Conversation
Member
Author
|
/test |
This commit fixes some errorhandling cases in the neighbor calculator where the value of the error is not checked before joining with other errors. This leads to the incorrect health status being reported. e.g. ``` desired neighbor calculator errored: failed to insert desired neighbor: %!w(<nil>)\nfailed to insert desired neighbor: %!w(<nil>) ``` Signed-off-by: Marco Hofstetter <marco.hofstetter@isovalent.com>
5c5e9d1 to
57b1a9b
Compare
Member
Author
|
rebased to |
Member
Author
|
/test |
Member
|
Could you update the PR description or PR title to provide a release note that users could better interpet? For instance, "Fix bug where neighbor discovery subsystem reports unhealthy when it is healthy" |
17 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit fixes some errorhandling cases in the neighbor calculator where the value of the error is not checked before joining with other errors.
This leads to the incorrect health status being reported.
e.g.
Note: NOT checking if an error is
nilbefore joining is fine. but in these cases the error that gets joined is nevernilbecause the actual error (that can be nil) gets wrapped.