Skip to content

install/kubernetes: fix clustermesh-apiserver extraEnv#41021

Merged
aanm merged 1 commit intomainfrom
pr/fix-clustermesh-extraenv
Aug 8, 2025
Merged

install/kubernetes: fix clustermesh-apiserver extraEnv#41021
aanm merged 1 commit intomainfrom
pr/fix-clustermesh-extraenv

Conversation

@aanm
Copy link
Copy Markdown
Member

@aanm aanm commented Aug 8, 2025

The location of the extraEnv should be under the 'env:' section. Having it out of place, causes the yaml to be incorrectly formatted preventing the user from using this helm variable.

Fixes: a39087e ("helm: add readinessProbe to clustermesh-apiserver")

Fix bug with clustermesh.apiserver.extraEnv that prevented the yaml file from being correctly generated.

The location of the extraEnv should be under the 'env:' section. Having
it out of place, causes the yaml to be incorrectly formatted preventing
the user from using this helm variable.

Fixes: a39087e ("helm: add readinessProbe to clustermesh-apiserver")
Signed-off-by: André Martins <andre@cilium.io>
@aanm aanm requested review from giorio94 and thorn3r August 8, 2025 10:39
@aanm aanm requested a review from a team as a code owner August 8, 2025 10:39
@aanm aanm added the kind/bug This is a bug in the Cilium logic. label Aug 8, 2025
@aanm aanm requested review from a team as code owners August 8, 2025 10:39
@aanm aanm added release-note/bug This PR fixes an issue in a previous release of Cilium. needs-backport/1.16 needs-backport/1.17 This PR / issue needs backporting to the v1.17 branch needs-backport/1.18 This PR / issue needs backporting to the v1.18 branch labels Aug 8, 2025
@aanm aanm requested review from brlbil and joamaki August 8, 2025 10:39
@aanm
Copy link
Copy Markdown
Member Author

aanm commented Aug 8, 2025

/test

@aanm aanm enabled auto-merge August 8, 2025 10:39
Copy link
Copy Markdown
Member

@giorio94 giorio94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@aanm aanm added this pull request to the merge queue Aug 8, 2025
Merged via the queue into main with commit 47eda94 Aug 8, 2025
381 of 386 checks passed
@aanm aanm deleted the pr/fix-clustermesh-extraenv branch August 8, 2025 12:25
@YutaroHayakawa YutaroHayakawa mentioned this pull request Aug 11, 2025
2 tasks
@YutaroHayakawa YutaroHayakawa mentioned this pull request Aug 11, 2025
3 tasks
@YutaroHayakawa YutaroHayakawa added backport-pending/1.17 The backport for Cilium 1.17.x for this PR is in progress. and removed needs-backport/1.17 This PR / issue needs backporting to the v1.17 branch labels Aug 11, 2025
@YutaroHayakawa YutaroHayakawa mentioned this pull request Aug 11, 2025
10 tasks
@YutaroHayakawa YutaroHayakawa added backport-pending/1.18 The backport for Cilium 1.18.x for this PR is in progress. and removed needs-backport/1.18 This PR / issue needs backporting to the v1.18 branch labels Aug 11, 2025
@github-actions github-actions bot added backport-done/1.16 The backport for Cilium 1.16.x for this PR is done. backport-done/1.17 The backport for Cilium 1.17.x for this PR is done. backport-done/1.18 The backport for Cilium 1.18.x for this PR is done. and removed backport-pending/1.16 backport-pending/1.17 The backport for Cilium 1.17.x for this PR is in progress. backport-pending/1.18 The backport for Cilium 1.18.x for this PR is in progress. labels Aug 12, 2025
@cilium-release-bot cilium-release-bot bot moved this to Released in cilium v1.19.0 Feb 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-done/1.16 The backport for Cilium 1.16.x for this PR is done. backport-done/1.17 The backport for Cilium 1.17.x for this PR is done. backport-done/1.18 The backport for Cilium 1.18.x for this PR is done. kind/bug This is a bug in the Cilium logic. release-note/bug This PR fixes an issue in a previous release of Cilium.

Projects

No open projects
Status: Released

Development

Successfully merging this pull request may close these issues.

5 participants