WIP: test ci clustermesh: cli: output cluster values to dict#40960
Closed
MrFreezeex wants to merge 4 commits intocilium:mainfrom
Closed
WIP: test ci clustermesh: cli: output cluster values to dict#40960MrFreezeex wants to merge 4 commits intocilium:mainfrom
MrFreezeex wants to merge 4 commits intocilium:mainfrom
Conversation
Member
Author
|
/test |
3e72b6c to
439433f
Compare
Member
Author
|
/test |
439433f to
25af2ba
Compare
Member
Author
|
/test |
dd8af94 to
04448c9
Compare
Member
Author
|
/test |
This commit adds support for setting ReuseValues to false in the helmUpgrade function. This is helpful to prepare for outputting `clustermesh.config.clusters` to a dict in the CLI and prevent uncontrolled deep merged if we were using ReuseValues. Since we now only need the clusters map and not the "full" values this commit rename a lot of code to replace most usage of "values" by "clusters". Signed-off-by: Arthur Outhenin-Chalandre <git@mrfreezeex.fr>
Output `clustermesh.config.clusters` to a dict if the cluster is running at least Cilium 1.20. We are choosing 1.20 since the dict format is supported from Cilium 1.19 and we do that in one additional minor version to allow users to downgrade and reusing the same values. Signed-off-by: Arthur Outhenin-Chalandre <git@mrfreezeex.fr>
Signed-off-by: Arthur Outhenin-Chalandre <git@mrfreezeex.fr>
This commit add initial support in Helm to pass a dict of clusters instead of a list of clusters. This fits more to our actual usage as each name are unique and a dict can enforce that by design. It will also allows users to split their clusters in multiple helm values files as a dict allow for deep-merging helm values while you cannot do that with a list. This also adds a enabled subkey in the clusters list which might allow for further flexibility to optionally declare but disable one cluster when merging Helm values together. This is only the initial support and don't include the CLI support. Signed-off-by: Arthur Outhenin-Chalandre <arthur@cri.epita.fr>
04448c9 to
62fc0f4
Compare
Member
Author
|
/test |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.