clustermesh: helm: add support for dict type for clusters values#40857
Merged
joestringer merged 1 commit intocilium:mainfrom Aug 12, 2025
Merged
Conversation
db16f43 to
90e869b
Compare
Member
Author
|
/test |
90e869b to
fb0e937
Compare
Member
Author
|
/test |
fb0e937 to
0f93f91
Compare
Member
Author
|
/test |
marseel
approved these changes
Aug 4, 2025
Member
marseel
left a comment
There was a problem hiding this comment.
Thanks for the PR, I think it would be nice to include some short message in upgrade notes as well highlighting new format.
0f93f91 to
75e9b5b
Compare
This commit add initial support in Helm to pass a dict of clusters instead of a list of clusters. This fits more to our actual usage as each name are unique and a dict can enforce that by design. It will also allows users to split their clusters in multiple helm values files as a dict allow for deep-merging helm values while you cannot do that with a list. This also adds a enabled subkey in the clusters list which might allow for further flexibility to optionally declare but disable one cluster when merging Helm values together. This is only the initial support and don't include the CLI support. Signed-off-by: Arthur Outhenin-Chalandre <arthur@cri.epita.fr>
75e9b5b to
cebf431
Compare
Member
Author
|
/test |
marseel
approved these changes
Aug 5, 2025
Artyop
approved these changes
Aug 6, 2025
tommyp1ckles
reviewed
Aug 7, 2025
tommyp1ckles
approved these changes
Aug 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit add initial support in Helm to pass a dict of clusters instead of a list of clusters.
This fits more to our actual usage as each name are unique and a dict can enforce that by design. It will also allows users to split their clusters in multiple helm values files as a dict allow for deep-merging helm values while you cannot do that with a list.
This also adds a enabled subkey in the clusters list which might allow for further flexibility to optionally declare but disable one cluster when merging Helm values together.
This is only the initial support and don't include the CLI support.
Related to #40796