Convert bpf endpoint config macros to load time config#40430
Merged
dylandreimerink merged 4 commits intocilium:mainfrom Aug 1, 2025
Merged
Convert bpf endpoint config macros to load time config#40430dylandreimerink merged 4 commits intocilium:mainfrom
dylandreimerink merged 4 commits intocilium:mainfrom
Conversation
d803cb6 to
0651f33
Compare
Member
Author
|
/test |
0651f33 to
7a2ce14
Compare
Member
Author
|
/test |
9700050 to
a6ab312
Compare
Member
Author
|
/test |
Contributor
This is :fine: and common, no worries. :) |
ti-mo
reviewed
Jul 11, 2025
Contributor
ti-mo
left a comment
There was a problem hiding this comment.
Thanks! Left a few considerations.
Signed-off-by: Deepesh Pathak <deepeshpathak09@gmail.com>
a6ab312 to
2346875
Compare
Signed-off-by: Deepesh Pathak <deepeshpathak09@gmail.com>
Signed-off-by: Deepesh Pathak <deepeshpathak09@gmail.com>
This commit refactors the evaluation of DirectRoutingDevice requirement to orchestrator simplifying the usage during load time. When reconciling LocalNodeConfig error out if Direct routing device is required but not yet configured. Signed-off-by: Deepesh Pathak <deepeshpathak09@gmail.com>
2346875 to
ce709ca
Compare
Member
Author
|
/ci-verifier |
Member
Author
|
/test |
dylandreimerink
approved these changes
Jul 21, 2025
Member
dylandreimerink
left a comment
There was a problem hiding this comment.
Taking over review for cilium/loader since Timo is not available for a bit.
Changes look good to me. I believe all of Timo's feedback has been processed. Thank you!
dylandreimerink
approved these changes
Aug 1, 2025
2 tasks
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Convert BPF macros to load time config:
HOST_EP_IDDIRECT_ROUTING_DEV_IFINDEXParent Issue: #38370