feat : implementation of BGP readiness probe by rabelmervin · Pull Request #40335 · cilium/cilium

rabelmervin · 2025-07-02T17:24:27Z

Fixes #39468

Add optional BGP readiness probe feedback into cilium-agent health status

maintainer-s-little-helper · 2025-07-02T17:30:09Z

Commit 9558c87 does not match "(?m)^Signed-off-by:".

Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin

maintainer-s-little-helper · 2025-07-02T17:45:58Z

Commit 9558c87 does not match "(?m)^Signed-off-by:".

Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin

gandro

Thank you! One last piece of feedback, then this looks good from my side. Please make sure to squash your commits and remove the merge commit (as discussed on Slack)

pkg/status/status_collector.go

maintainer-s-little-helper · 2025-07-03T11:54:13Z

Commit 9558c87 does not match "(?m)^Signed-off-by:".

Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin

squeed · 2025-07-03T11:55:19Z

install/kubernetes/cilium/values.yaml.tmpl

    ipPool: ""
+  # -- BGP readiness settings
+  bgpReadiness:
+    # -- Enable/Disable BGP readiness.


Can you add a bit more information here? e.g. "When enabled, Cilium pods will not be marked as Ready until configured BGP sessions have been established"

squeed · 2025-07-03T11:58:30Z

Do we need to worry about a flaky peer causing all pods to go non-Ready? I see that we mark the agent as ready as long as a single peer is up, which is a good idea. We might want to permanently mark the agent as ready once a single session has been fully established. Thoughts (@YutaroHayakawa)?

gandro

Thanks. Two formatting issues appeared. Other than that looks good. Please make sure to squash your commits again!

gandro · 2025-07-03T13:06:41Z

pkg/bgpv1/healthcheck/healthcheck.go

+package healthcheck
+
+import (
+	"context"


The imports here are now no longer properly formatted

This is an issue again

pkg/status/cell.go

maintainer-s-little-helper · 2025-07-03T14:34:37Z

Commit 9558c87 does not match "(?m)^Signed-off-by:".

Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin

YutaroHayakawa · 2025-07-03T20:10:35Z

Do we need to worry about a flaky peer causing all pods to go non-Ready? I see that we mark the agent as ready as long as a single peer is up, which is a good idea. We might want to permanently mark the agent as ready once a single session has been fully established. Thoughts (@YutaroHayakawa)?

Yeah, given the use case in the original issue (the agent rollout scenario), this makes sense I think. Because we're only interested in the initial readiness in that case. @pasteley, do you have any thoughts around that?

pasteley · 2025-07-04T09:25:00Z

Do we need to worry about a flaky peer causing all pods to go non-Ready? I see that we mark the agent as ready as long as a single peer is up, which is a good idea. We might want to permanently mark the agent as ready once a single session has been fully established. Thoughts (@YutaroHayakawa)?

Yeah, given the use case in the original issue (the agent rollout scenario), this makes sense I think. Because we're only interested in the initial readiness in that case. @pasteley, do you have any thoughts around that?

Agree, but does it mean that startupProbe should be used instead?
Something like:

startupProbe:
  httpGet:
    path: /bgp/status
    port: 9879
  failureThreshold: 30
  periodSeconds: 10

YutaroHayakawa · 2025-07-07T18:27:06Z

Agree, but does it mean that startupProbe should be used instead?

Yeah, makes sense to me. However I think we either need to introduce an endpoint dedicated for the startupProbe or introduce modifier to distinguish startup vs readiness in the /healthz endpoint in that case. Implementing it on the existing /healthz doesn't work because it is also used in the readiness probe.

That's gonna be an overkill for this small use case IMO, so I'd vote for the stateful approach that Casey mentioned (mark BGP "ready" permanently after initial session establishment).

Signed-off-by: rabelmervin <rabelmervin@gmail.com>

install/kubernetes/cilium/values.yaml.tmpl

pkg/bgpv1/healthcheck/healthcheck.go

Signed-off-by: rabelmervin <rabelmervin@gmail.com>

dylandreimerink · 2025-07-14T07:53:52Z

/test

gandro

Thanks! Please make sure to address the unresolved feedback and squash your commits into one again.

gandro · 2025-07-14T08:07:23Z

Also note that CI is failing because the Helm and API files need to be re-generated.

joestringer · 2025-07-17T00:13:17Z

api/v1/openapi.yaml

Is the API change necessary if there's just a commandline flag for this?

The intent for API change would be if there is a flag on the cilium-dbg status ... command-line to optionally require BGP readiness in certain scenarios. If instead you're deploying the cilium-agent with a static requirement based on a cilium-agent flag, then you don't need these API changes at all.

joestringer · 2025-07-17T00:16:39Z

Converting to draft while you address the feedback. When that is complete, use the "ready for review" button at the bottom of the page.

I also added a proposed release note into the description to help communicate this feature more clearly to users.

github-actions · 2025-08-16T02:10:15Z

This pull request has been automatically marked as stale because it
has not had recent activity. It will be closed if no further activity
occurs. Thank you for your contributions.

github-actions · 2025-08-31T02:08:33Z

This pull request has not seen any activity since it was marked stale.
Closing.

rabelmervin · 2025-11-02T09:01:37Z

This pull request has not seen any activity since it was marked stale. Closing.

still working on this

Signed-off-by: rabelmervin <rabelmervin@gmail.com>

github-actions · 2026-02-16T02:14:29Z

This pull request has been automatically marked as stale because it
has not had recent activity. It will be closed if no further activity
occurs. Thank you for your contributions.

github-actions · 2026-03-03T02:14:01Z

This pull request has not seen any activity since it was marked stale.
Closing.

rabelmervin requested review from a team as code owners July 2, 2025 17:24

rabelmervin requested review from harsimran-pabla and thorn3r July 2, 2025 17:24

maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jul 2, 2025

rabelmervin requested review from aanm and squeed July 2, 2025 17:24

github-actions bot added the kind/community-contribution This was a contribution made by a community member. label Jul 2, 2025

maintainer-s-little-helper bot added the dont-merge/needs-sign-off The author needs to add signoff to their commits before merge. label Jul 2, 2025

gandro reviewed Jul 3, 2025

View reviewed changes

pkg/status/status_collector.go Show resolved Hide resolved

squeed reviewed Jul 3, 2025

View reviewed changes

gandro reviewed Jul 3, 2025

View reviewed changes

rabelmervin force-pushed the bgp branch from fbbfe9e to 2845ec8 Compare July 9, 2025 07:01

maintainer-s-little-helper bot removed the dont-merge/needs-sign-off The author needs to add signoff to their commits before merge. label Jul 9, 2025

Update BGP healthcheck

447e454

Signed-off-by: rabelmervin <rabelmervin@gmail.com>

rabelmervin force-pushed the bgp branch from 2845ec8 to 447e454 Compare July 9, 2025 07:10

gandro reviewed Jul 9, 2025

View reviewed changes

install/kubernetes/cilium/values.yaml.tmpl Outdated Show resolved Hide resolved

pkg/bgpv1/healthcheck/healthcheck.go Show resolved Hide resolved

success state

42cb5e2

Signed-off-by: rabelmervin <rabelmervin@gmail.com>

gandro reviewed Jul 14, 2025

View reviewed changes

joestringer added the release-note/minor This PR changes functionality that users may find relevant to operating Cilium. label Jul 17, 2025

maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jul 17, 2025

joestringer marked this pull request as draft July 17, 2025 00:09

joestringer reviewed Jul 17, 2025

View reviewed changes

github-actions bot added the stale The stale bot thinks this issue is old. Add "pinned" label to prevent this from becoming stale. label Aug 16, 2025

github-actions bot closed this Aug 31, 2025

rabelmervin added 4 commits January 16, 2026 15:23

test: add BGP readiness unit tests and CLI command

a5a6999

Signed-off-by: rabelmervin <rabelmervin@gmail.com>

install: update Helm templates

9fae880

Signed-off-by: rabelmervin <rabelmervin@gmail.com>

cmd: update status command for BGP readiness

d5ec31d

Signed-off-by: rabelmervin <rabelmervin@gmail.com>

feat(bgp): implement BGP readiness probe feature

5e099ef

Signed-off-by: rabelmervin <rabelmervin@gmail.com>

joestringer reopened this Jan 16, 2026

github-actions bot removed the stale The stale bot thinks this issue is old. Add "pinned" label to prevent this from becoming stale. label Jan 17, 2026

github-actions bot added the stale The stale bot thinks this issue is old. Add "pinned" label to prevent this from becoming stale. label Feb 16, 2026

github-actions bot closed this Mar 3, 2026

Conversation

rabelmervin commented Jul 2, 2025 • edited by joestringer Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Fixes #39468

Uh oh!

maintainer-s-little-helper bot commented Jul 2, 2025

Uh oh!

maintainer-s-little-helper bot commented Jul 2, 2025

Uh oh!

gandro left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

maintainer-s-little-helper bot commented Jul 3, 2025

Uh oh!

squeed Jul 3, 2025

Choose a reason for hiding this comment

Uh oh!

squeed commented Jul 3, 2025

Uh oh!

gandro left a comment

Choose a reason for hiding this comment

Uh oh!

gandro Jul 3, 2025

Choose a reason for hiding this comment

Uh oh!

gandro Jul 14, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

maintainer-s-little-helper bot commented Jul 3, 2025

Uh oh!

YutaroHayakawa commented Jul 3, 2025

Uh oh!

pasteley commented Jul 4, 2025

Uh oh!

YutaroHayakawa commented Jul 7, 2025

Uh oh!

Uh oh!

Uh oh!

dylandreimerink commented Jul 14, 2025

Uh oh!

gandro left a comment

Choose a reason for hiding this comment

Uh oh!

gandro commented Jul 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

joestringer Jul 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

joestringer commented Jul 17, 2025

Uh oh!

github-actions bot commented Aug 16, 2025

Uh oh!

github-actions bot commented Aug 31, 2025

Uh oh!

rabelmervin commented Nov 2, 2025

Uh oh!

github-actions bot commented Feb 16, 2026

Uh oh!

github-actions bot commented Mar 3, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

rabelmervin commented Jul 2, 2025 •

edited by joestringer

Loading

gandro commented Jul 14, 2025 •

edited

Loading

joestringer Jul 17, 2025 •

edited

Loading