Skip to content

connectivity: Add tests for L7 LB feature#39577

Merged
sayboras merged 1 commit intomainfrom
pr/tammach/samepod-routing
Jun 5, 2025
Merged

connectivity: Add tests for L7 LB feature#39577
sayboras merged 1 commit intomainfrom
pr/tammach/samepod-routing

Conversation

@sayboras
Copy link
Copy Markdown
Member

@sayboras sayboras commented May 16, 2025 •
edited
Loading

Please refer to individual commit for more details

Testing was done in https://github.com/cilium/cilium/actions/runs/15457715895, the new tests are running successfully 5 consecutive times.

@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label May 16, 2025
@github-actions github-actions bot added the cilium-cli This PR contains changes related with cilium-cli label May 16, 2025
@sayboras sayboras added release-note/bug This PR fixes an issue in a previous release of Cilium. and removed cilium-cli This PR contains changes related with cilium-cli labels May 16, 2025
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label May 16, 2025
@sayboras sayboras changed the title Pr/tammach/samepod routing proxy: Fix connectivity issue for L7 service hairpinning May 16, 2025
@sayboras
Copy link
Copy Markdown
Member Author

sayboras commented May 16, 2025

/test

@sayboras sayboras marked this pull request as ready for review May 16, 2025 14:53
@sayboras sayboras requested review from a team as code owners May 16, 2025 14:53
@sayboras sayboras force-pushed the pr/tammach/samepod-routing branch from b6b166b to cdf3dd9 Compare May 16, 2025 22:42
@sayboras
Copy link
Copy Markdown
Member Author

sayboras commented May 17, 2025

/test

@sayboras sayboras mentioned this pull request May 17, 2025
Merged
@rauanmayemir
Copy link
Copy Markdown
Contributor

rauanmayemir commented May 18, 2025

Tried upgrading from v1.16 to v1.17 branch and might have hit this bad.
Services that relied on global endpoints in the same cluster (i.e resolves outside of cilium, but then comes back to the same cluster) were failing to connect.

@sayboras
Copy link
Copy Markdown
Member Author

sayboras commented May 19, 2025

Tried upgrading from v1.16 to v1.17 branch and might have hit this bad. Services that relied on global endpoints in the same cluster (i.e resolves outside of cilium, but then comes back to the same cluster) were failing to connect.

Thanks for chiming in.

Just curious if you have the change to test it out, the latest 1.17 branch should include cilium/proxy fix

#39570

@rauanmayemir
Copy link
Copy Markdown
Contributor

rauanmayemir commented May 19, 2025

I've already gnawed through the downtime budget, can't do it now. 🫠

After the v1.17 fiasco I tried doing minor bump from v1.16.4 to v.16.10 and still got same issues.
I had a TLSRoute that kept failing with curl: (35) Recv failure: Connection reset by peer from inside the cluster, but was fine accessing from the outside.

@sayboras
Copy link
Copy Markdown
Member Author

sayboras commented May 19, 2025

oh sorry to hear that.

Just a note that this issue happens for 1.15+, all the latest stable branches are updated as per below.

v1.17: #39570
v1.16: #39591
v1.15: #39592

jrajahalme
jrajahalme approved these changes May 19, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@jrajahalme jrajahalme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with 2 nits you may want to address :-)

@sayboras sayboras force-pushed the pr/tammach/samepod-routing branch from cdf3dd9 to 48bb15a Compare May 20, 2025 05:45
@sayboras sayboras marked this pull request as draft May 21, 2025 03:23
@sayboras sayboras force-pushed the pr/tammach/samepod-routing branch 2 times, most recently from 4716871 to 9dbbd0e Compare May 24, 2025 14:36
@sayboras sayboras force-pushed the pr/tammach/samepod-routing branch from 9dbbd0e to 7f31edd Compare June 5, 2025 03:25
@sayboras
connectivity: Add tests for L7 LB feature
6e5af50 
As a first cut, only one simple test without CNP is added. More tests
will be covered later.

Signed-off-by: Tam Mach <tam.mach@cilium.io>
@sayboras sayboras force-pushed the pr/tammach/samepod-routing branch from 7f31edd to 6e5af50 Compare June 5, 2025 03:26
@sayboras sayboras marked this pull request as ready for review June 5, 2025 03:36
@sayboras
Copy link
Copy Markdown
Member Author

sayboras commented Jun 5, 2025

/test

@sayboras sayboras removed the request for review from a team June 5, 2025 06:10
@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Jun 5, 2025
@sayboras sayboras added this pull request to the merge queue Jun 5, 2025
Merged via the queue into main with commit 4ca43c4 Jun 5, 2025
239 of 241 checks passed
@sayboras sayboras deleted the pr/tammach/samepod-routing branch June 5, 2025 06:48
julianwiedmann
julianwiedmann reviewed Sep 1, 2025
View reviewed changes
@julianwiedmann julianwiedmann added release-note/ci This PR makes changes to the CI. cilium-cli This PR contains changes related with cilium-cli cilium-cli-exclusive This PR only impacts cilium-cli binary and removed release-note/bug This PR fixes an issue in a previous release of Cilium. labels Sep 4, 2025
@julianwiedmann julianwiedmann mentioned this pull request Sep 4, 2025
Closed
3 tasks
sayboras added a commit that referenced this pull request Sep 5, 2025
@sayboras
test: Extend L7LB test for ipv6
3abd273 
Relates: #39577 (comment)

Suggested-by: Julian Wiedmann <jwi@isovalent.com>
Signed-off-by: Tam Mach <tam.mach@cilium.io>
@sayboras sayboras mentioned this pull request Sep 5, 2025
Merged
sayboras added a commit that referenced this pull request Sep 5, 2025
@sayboras
test: Extend L7LB test for ipv6
47638a4 
Relates: #39577 (comment)

Suggested-by: Julian Wiedmann <jwi@isovalent.com>
Signed-off-by: Tam Mach <tam.mach@cilium.io>
sayboras added a commit that referenced this pull request Sep 7, 2025
@sayboras
test: Extend L7LB test for ipv6
c0815c2 
Relates: #39577 (comment)

Suggested-by: Julian Wiedmann <jwi@isovalent.com>
Signed-off-by: Tam Mach <tam.mach@cilium.io>
@aanm aanm mentioned this pull request Sep 8, 2025
Closed
github-merge-queue bot pushed a commit that referenced this pull request Sep 9, 2025
@sayboras
test: Extend L7LB test for ipv6
ce76111 
Relates: #39577 (comment)

Suggested-by: Julian Wiedmann <jwi@isovalent.com>
Signed-off-by: Tam Mach <tam.mach@cilium.io>
jarrodb pushed a commit to 46labs/cilium that referenced this pull request Sep 10, 2025
@sayboras @jarrodb
test: Extend L7LB test for ipv6
e22262c 
Relates: cilium#39577 (comment)

Suggested-by: Julian Wiedmann <jwi@isovalent.com>
Signed-off-by: Tam Mach <tam.mach@cilium.io>
NihaNallappagari pushed a commit to NihaNallappagari/cilium that referenced this pull request Sep 17, 2025
@sayboras @NihaNallappagari
test: Extend L7LB test for ipv6
a520237 
Relates: cilium#39577 (comment)

Suggested-by: Julian Wiedmann <jwi@isovalent.com>
Signed-off-by: Tam Mach <tam.mach@cilium.io>
julianwiedmann
julianwiedmann reviewed Jan 7, 2026
View reviewed changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@julianwiedmann julianwiedmann julianwiedmann left review comments

@derailed derailed derailed approved these changes

@gandro gandro gandro approved these changes

@marseel marseel marseel approved these changes

@ysksuzuki ysksuzuki ysksuzuki approved these changes

@jrajahalme jrajahalme jrajahalme approved these changes

@Artyop Artyop Artyop approved these changes

Assignees

No one assigned

Labels

cilium-cli This PR contains changes related with cilium-cli cilium-cli-exclusive This PR only impacts cilium-cli binary ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/ci This PR makes changes to the CI.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.