cli: Load code owners dynamically via --code-owners#38044
Merged
joestringer merged 2 commits intomainfrom Mar 7, 2025
Merged
Conversation
asauber
approved these changes
Mar 6, 2025
Embedding the code owners into the CLI from the top of the tree was a nice trick, but it's a bit restrictive. Looking forward, we would like to have the review code owners diverge from test owners in some narrow use cases such as on stable branches or on the cilium-cli repository where the paths differ from the main cilium tree. As such, it would be useful to be able to override the existing code owners rule sets by specifying the path to one or more CODEOWNERS-style files on the command-line when running these tests. Signed-off-by: Joe Stringer <joe@cilium.io>
ac90441 to
2d74c84
Compare
christarazi
approved these changes
Mar 6, 2025
2d74c84 to
0ddba9a
Compare
Embedding the code owners into the CLI from the top of the tree was a nice trick, but it's a bit restrictive. Looking forward, we would like to have the review code owners diverge from test owners in some narrow use cases such as on stable branches or on the cilium-cli repository where the paths differ from the main cilium tree. As such, it would be useful to be able to override the existing code owners rule sets by specifying the path to one or more CODEOWNERS-style files on the command-line when running these tests. Subsequent commits will introduce the GitHub workflow changes to leverage these changes. Signed-off-by: Joe Stringer <joe@cilium.io>
0ddba9a to
fec2ee0
Compare
Member
Author
|
/test |
giorio94
reviewed
Mar 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Embedding the code owners into the CLI from the top of the tree was a
nice trick, but it's a bit restrictive. Looking forward, we would like
to have the review code owners diverge from test owners in some narrow
use cases such as on stable branches or on the cilium-cli repository
where the paths differ from the main cilium tree. As such, it would be
useful to be able to override the existing code owners rule sets by
specifying the path to one or more CODEOWNERS-style files on the
command-line when running these tests.
Subsequent commits will introduce the GitHub workflow changes to
leverage these changes: #38045