netkit: Don't let systemd change the MAC address#37812
Merged
tklauser merged 2 commits intocilium:mainfrom Mar 4, 2025
Merged
Conversation
64d4a12 to
8d7e836
Compare
Contributor
Author
|
FYI @borkmann |
Member
lgtm, thanks! |
borkmann
approved these changes
Feb 26, 2025
20e533c to
36b4c5c
Compare
Fixes: cilium#37265 Signed-off-by: Jordan Rife <jrife@google.com>
Systemd will change the random MAC addresses generated for a netkit device pair when MACAddressPolicy=persistent, seemingly the default on my system and presumably others. Apply the same workaround used in SetupVethWithNames() where we "manually" generate and assign a MAC address for both the primary and peer devices, so that Systemd doesn't do this. Fixes: cilium#37265 Signed-off-by: Jordan Rife <jrife@google.com>
Member
|
/test |
tklauser
approved these changes
Mar 4, 2025
|
Hi @jrife, thank you so much for adding this PR. Which version it will be available? I just checked the new release v.1.17.2 and I didn't find this PR on the release notes. |
Contributor
Author
|
@gcezaralmeida, this isn't currently marked for backport, but I'll check to see if it can be. |
16 tasks
|
Big shout out to @jrife, thank you so much. I updated to 1.17.3 and it is working fine with Kubevirt. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Systemd will change the random MAC addresses generated for a netkit device pair when MACAddressPolicy=persistent, seemingly the default on my system and presumably others. Apply the same workaround used in SetupVethWithNames() where "manually" generate and assign a MAC address for both the primary and peer devices, so that Systemd doesn't do this.
Fixes: #37265