Revert "contrib: Run builder script as non-root by default"#37736
Merged
aanm merged 1 commit intocilium:mainfrom Feb 19, 2025
Merged
Revert "contrib: Run builder script as non-root by default"#37736aanm merged 1 commit intocilium:mainfrom
aanm merged 1 commit intocilium:mainfrom
Conversation
This reverts commit cc59b47. Signed-off-by: Jarno Rajahalme <jarno@isovalent.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Running build script as non-root breaks running bpf tests (
make run_bpf_tests). There seems to be no way of reversing the defaultRUN_AS_NONROOT, as setting it to empty or0does not work. Maybe the logic needs to be reverted and have aRUN_AS_ROOTinstead?This reverts commit cc59b47.