Skip to content

workflows/e2e: Revert bpf/bpf-next image updates#37485

Merged
pchaigno merged 1 commit intomainfrom
pr/pchaigno/revert-ci-image-update
Feb 10, 2025
Merged

workflows/e2e: Revert bpf/bpf-next image updates#37485
pchaigno merged 1 commit intomainfrom
pr/pchaigno/revert-ci-image-update

Conversation

@pchaigno
Copy link
Copy Markdown
Member

@pchaigno pchaigno commented Feb 7, 2025

This partially reverts pull request #37406.

That commit introduced a fairly frequent flake on bpf-next and bpf kernels in our end-to-end suite, with connectivity being interrupted during upgrades from v1.17. IPsec end-to-end tests were not impacted because they were not updated. The present commit reverts the change and blocks future updates of the bpf and bpf-next images for the time being.

I ran the workflow 10 times at https://github.com/cilium/cilium/actions/runs/13204674613 and couldn't reproduce the issue.

Updates: #37520.

@pchaigno pchaigno added the release-note/ci This PR makes changes to the CI. label Feb 7, 2025
@jschwinger233
Copy link
Copy Markdown
Member

Could it be cilium/little-vm-helper-images#850 😬

@pchaigno
Copy link
Copy Markdown
Member Author

@jschwinger233 The symptoms look different. We have pods restarting during the upgrade in my case.

This partially reverts commit 86639d0 ("chore(deps): update all
lvh-images main").

That commit introduced a fairly frequent flake on bpf-next and bpf
kernels in our end-to-end suite, with connectivity being interrupted
during upgrades from v1.17. IPsec end-to-end tests were not impacted
because they were not updated. The present commit reverts the change and
blocks future updates of the bpf and bpf-next images for the time being.

Signed-off-by: Paul Chaignon <paul.chaignon@gmail.com>
@pchaigno pchaigno force-pushed the pr/pchaigno/revert-ci-image-update branch from b2918f4 to f08ae87 Compare February 10, 2025 11:06
@pchaigno
Copy link
Copy Markdown
Member Author

/test

@pchaigno pchaigno changed the title Revert "chore(deps): update all lvh-images main" workflows/e2e: Revert bpf/bpf-next image updates Feb 10, 2025
@pchaigno pchaigno marked this pull request as ready for review February 10, 2025 11:15
@pchaigno pchaigno requested review from a team as code owners February 10, 2025 11:15
@pchaigno pchaigno requested a review from brlbil February 10, 2025 11:15
@julianwiedmann julianwiedmann added the dependencies Pull requests that update a dependency file label Feb 10, 2025
Copy link
Copy Markdown
Member

@julianwiedmann julianwiedmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Needed to remind myself that the ginkgo upgrade test is gone, and that's why we don't need to touch the ginkgo dependency.

@pchaigno pchaigno enabled auto-merge February 10, 2025 11:41
@pchaigno pchaigno added this pull request to the merge queue Feb 10, 2025
@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Feb 10, 2025
Merged via the queue into main with commit 8b1e35d Feb 10, 2025
@pchaigno pchaigno deleted the pr/pchaigno/revert-ci-image-update branch February 10, 2025 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/ci This PR makes changes to the CI.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants