bpf: remove dynamic map names and map macros#37469
Merged
ti-mo merged 33 commits intocilium:mainfrom Mar 13, 2025
Merged
Conversation
Contributor
Author
|
/test |
fc7d4e9 to
7ae6652
Compare
Contributor
Author
|
/test |
7ae6652 to
515bb7c
Compare
Contributor
Author
|
/test |
515bb7c to
4ac4783
Compare
Contributor
Author
|
/test |
4ac4783 to
547ee89
Compare
Contributor
Author
|
/test |
547ee89 to
228c3db
Compare
Contributor
Author
|
/test |
228c3db to
2e0a4ae
Compare
Contributor
Author
|
/test |
1 similar comment
Contributor
Author
|
/test |
2e0a4ae to
4f095e0
Compare
Contributor
Author
|
/test |
Signed-off-by: Timo Beckers <timo@isovalent.com>
Signed-off-by: Timo Beckers <timo@isovalent.com>
Signed-off-by: Timo Beckers <timo@isovalent.com>
Signed-off-by: Timo Beckers <timo@isovalent.com>
Signed-off-by: Timo Beckers <timo@isovalent.com>
Signed-off-by: Timo Beckers <timo@isovalent.com>
Also dropped __NR_CPUS__ from the map's maxentries, ebpf-go takes care of setting this at load time. Signed-off-by: Timo Beckers <timo@isovalent.com>
…acro Signed-off-by: Timo Beckers <timo@isovalent.com>
Signed-off-by: Timo Beckers <timo@isovalent.com>
Signed-off-by: Timo Beckers <timo@isovalent.com>
Signed-off-by: Timo Beckers <timo@isovalent.com>
Signed-off-by: Timo Beckers <timo@isovalent.com>
Signed-off-by: Timo Beckers <timo@isovalent.com>
Signed-off-by: Timo Beckers <timo@isovalent.com>
Signed-off-by: Timo Beckers <timo@isovalent.com>
Signed-off-by: Timo Beckers <timo@isovalent.com>
Signed-off-by: Timo Beckers <timo@isovalent.com>
Signed-off-by: Timo Beckers <timo@isovalent.com>
Signed-off-by: Timo Beckers <timo@isovalent.com>
Signed-off-by: Timo Beckers <timo@isovalent.com>
1877485 to
13dc40c
Compare
Contributor
Author
|
/test |
borkmann
approved these changes
Mar 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #34706
This PR removes all macros used for referring to maps that have been copy-pasta'd for an eternity. This is a requirement for getting to clang-free. The macros have been redundant since switching to ebpf-go for loading the datapath and were only needed for the few per-endpoint maps with dynamic names to begin with, yet here we are.
There are a few other benefits to doing this:
WriteNodeConfig(), which will need to be ported as a whole to the new runtime datapath config framework