ci: modify bpftrace script to ignore destinations outside pod CIDRs#36364
Merged
ci: modify bpftrace script to ignore destinations outside pod CIDRs#36364
Conversation
Contributor
Author
|
/ci-ipsec-e2e |
Contributor
Author
|
1st run of Also here:
Attaching sysdump for debugging in the other issue cilium-sysdumps.zip. Re-triggering test, the flake is not introduced in this PR. |
Contributor
Author
|
2nd run all 🟢 |
This was referenced Dec 4, 2024
Contributor
Author
|
/test |
3ac02f0 to
6a4a1d1
Compare
Contributor
Author
|
3rd run was green, but need to rebase due to other CI panics. |
Contributor
Author
|
/test |
pchaigno
reviewed
Dec 11, 2024
Member
pchaigno
left a comment
There was a problem hiding this comment.
Nice!
One question below. I'm not very familiar with the bpftrace script, so trying to make sure I understand things correctly.
6a4a1d1 to
5124e01
Compare
5124e01 to
a83da4b
Compare
Contributor
Author
|
/test |
45 tasks
19 tasks
6 tasks
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With this PR, the bpftrace script that we run in CI is now able to ignore TCP traffic with destionation address outside pod CIDRs. This is particularly useful in egress-gateway tests, for which pod-to-world and pod-to-node traffic is sent.
Prior to this, in conformance-ipsec-e2e we used to keep tests separate, and run bpftrace only on non egress-gateway tests.
This PR (re)unifies tests while also running bpftrace in background for all of them.