docs: Clarify instructions for bumping K8s to avoid forks#34791
Merged
christarazi merged 2 commits intocilium:mainfrom Sep 11, 2024
Merged
docs: Clarify instructions for bumping K8s to avoid forks#34791christarazi merged 2 commits intocilium:mainfrom
christarazi merged 2 commits intocilium:mainfrom
Conversation
Member
Author
|
/test |
qmonnet
approved these changes
Sep 9, 2024
Member
qmonnet
left a comment
There was a problem hiding this comment.
Looks good! Non-blocking nits below
aanm
requested changes
Sep 10, 2024
ec5c447 to
c03a300
Compare
Opening a PR against a branch on a fork won't properly test all of the changes in the PR because parts of the CI suite don't pick up the changes in the workflows for security reasons. Signed-off-by: Chris Tarazi <chris@isovalent.com>
Suggested-by: André Martins <andre@cilium.io> Signed-off-by: Chris Tarazi <chris@isovalent.com>
c03a300 to
be2ece0
Compare
Member
Author
|
/test |
aanm
approved these changes
Sep 11, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Opening a PR against a branch on a fork won't properly test all of the
changes in the PR because parts of the CI suite don't pick up the
changes in the workflows for security reasons.
Signed-off-by: Chris Tarazi chris@isovalent.com