Add Volcengine ENI IPAM fields into CiliumNode CRD#34608
Closed
ruicao93 wants to merge 1 commit intocilium:mainfrom
Closed
Add Volcengine ENI IPAM fields into CiliumNode CRD#34608ruicao93 wants to merge 1 commit intocilium:mainfrom
ruicao93 wants to merge 1 commit intocilium:mainfrom
Conversation
Fixes:cilium#34604 Signed-off-by: Rui Cao <caorui.io@bytedance.com>
4 tasks
Member
|
Thanks for the proposal. I've cc'd @cilium/sig-ipam for review. We probably also want to allocate the new files to ownership by @cilium/sig-ipam in the CODEOWNERS file. |
Member
|
Let's first discuss the proposal in the linked issue before decide to merge, as I think there are potentially other ways to implement this. |
Contributor
|
Can we mark this PR as a draft in the meantime? |
|
This pull request has been automatically marked as stale because it |
|
This pull request has not seen any activity since it was marked stale. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add Volcengine ENI IPAM fields into CiliumNode CRD as part of support for Volcengine cloud ENI IPAM.
Fixes:#34604