Skip to content

bpf: Refactor LRP per packet LB test to utilize helper functions. #34443

Merged
joestringer merged 2 commits intocilium:mainfrom
pravk03:pr/refactor-lrp-loopback-bpf-test
Aug 30, 2024
Merged

bpf: Refactor LRP per packet LB test to utilize helper functions. #34443
joestringer merged 2 commits intocilium:mainfrom
pravk03:pr/refactor-lrp-loopback-bpf-test

Conversation

@pravk03
Copy link
Copy Markdown

@pravk03 pravk03 commented Aug 18, 2024

Use helper functions from from bpf/tests/lib/.... in LRP loopback bpf test.
Remove redundant details from LRP documentation.

bpf: Refactor LRP per packet LB test to utilize helper functions. Remove redundant details from LRP documentation.

@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Aug 18, 2024
@github-actions github-actions bot added the kind/community-contribution This was a contribution made by a community member. label Aug 18, 2024
@pravk03 pravk03 force-pushed the pr/refactor-lrp-loopback-bpf-test branch from 46b80fd to bd017cc Compare August 19, 2024 03:01
@pravk03
Copy link
Copy Markdown
Author

pravk03 commented Aug 19, 2024

cc @julianwiedmann

@pravk03 pravk03 marked this pull request as ready for review August 19, 2024 03:03
@pravk03 pravk03 requested review from a team as code owners August 19, 2024 03:03
@pravk03 pravk03 requested review from aspsk and learnitall August 19, 2024 03:03
@ldelossa ldelossa added area/datapath Impacts bpf/ or low-level forwarding details, including map management and monitor messages. area/lrp Impacts Local Redirect Policy. labels Aug 21, 2024
@julianwiedmann julianwiedmann added the release-note/misc This PR makes changes that have no direct user impact. label Aug 21, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Aug 21, 2024
Copy link
Copy Markdown
Member

@julianwiedmann julianwiedmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thank you!

@pravk03 pravk03 force-pushed the pr/refactor-lrp-loopback-bpf-test branch 2 times, most recently from 5589ef1 to 7b88e2e Compare August 21, 2024 18:57
Copy link
Copy Markdown
Contributor

@aspsk aspsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one small formatting fix

@pravk03 pravk03 force-pushed the pr/refactor-lrp-loopback-bpf-test branch from 7b88e2e to 9de4cdb Compare August 23, 2024 16:34
@julianwiedmann
Copy link
Copy Markdown
Member

/test

@pravk03 pravk03 force-pushed the pr/refactor-lrp-loopback-bpf-test branch from 9de4cdb to ca58eff Compare August 25, 2024 16:06
Copy link
Copy Markdown
Contributor

@learnitall learnitall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Use helper functions from bpf/tests/lib/.....

Signed-off-by: Praveen Krishna <pkrishn@google.com>
Signed-off-by: Praveen Krishna <pkrishn@google.com>
@pravk03 pravk03 force-pushed the pr/refactor-lrp-loopback-bpf-test branch from ca58eff to d7611b9 Compare August 28, 2024 17:47
@julianwiedmann
Copy link
Copy Markdown
Member

/test

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Aug 29, 2024
@joestringer joestringer added this pull request to the merge queue Aug 30, 2024
Merged via the queue into cilium:main with commit 738202e Aug 30, 2024
@ysksuzuki ysksuzuki added backport/author The backport will be carried out by the author of the PR. needs-backport/1.16 labels Sep 24, 2024
@julianwiedmann julianwiedmann added backport-done/1.16 The backport for Cilium 1.16.x for this PR is done. and removed needs-backport/1.16 labels Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/datapath Impacts bpf/ or low-level forwarding details, including map management and monitor messages. area/lrp Impacts Local Redirect Policy. backport/author The backport will be carried out by the author of the PR. backport-done/1.16 The backport for Cilium 1.16.x for this PR is done. kind/community-contribution This was a contribution made by a community member. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants