Skip to content

policy: Fix mapstate.Diff() used in tests#33449

Merged
squeed merged 1 commit intocilium:mainfrom
jrajahalme:policy-fix-diff-for-tests
Jul 4, 2024
Merged

policy: Fix mapstate.Diff() used in tests#33449
squeed merged 1 commit intocilium:mainfrom
jrajahalme:policy-fix-diff-for-tests

Conversation

@jrajahalme
Copy link
Copy Markdown
Member

@jrajahalme jrajahalme commented Jun 28, 2024

Use the actual unexpected value, rather then the one that was not found.

Remove the import of unused "testing" from production code.

Fixes: #29162

@jrajahalme jrajahalme added kind/bug/CI This is a bug in the testing code. release-note/misc This PR makes changes that have no direct user impact. labels Jun 28, 2024
@jrajahalme jrajahalme requested a review from a team as a code owner June 28, 2024 08:24
@jrajahalme jrajahalme requested a review from derailed June 28, 2024 08:24
@jrajahalme jrajahalme added the sig/policy Impacts whether traffic is allowed or denied based on user-defined policies. label Jun 28, 2024
Copy link
Copy Markdown
Contributor

@derailed derailed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jrajahalme Great catch!

@jrajahalme
Copy link
Copy Markdown
Member Author

/test

Use the actual unexpected value, rather then the one that was not found.

Remove the import of unused "testing" from production code.

Signed-off-by: Jarno Rajahalme <jarno@isovalent.com>
@jrajahalme jrajahalme force-pushed the policy-fix-diff-for-tests branch from a65367a to 493c510 Compare July 1, 2024 07:58
@jrajahalme jrajahalme requested a review from a team as a code owner July 1, 2024 07:58
@jrajahalme jrajahalme requested a review from squeed July 1, 2024 07:58
@jrajahalme
Copy link
Copy Markdown
Member Author

/test

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Jul 4, 2024
@squeed squeed added this pull request to the merge queue Jul 4, 2024
Merged via the queue into cilium:main with commit f5f1e5a Jul 4, 2024
@jibi jibi mentioned this pull request Jul 8, 2024
32 tasks
@jibi jibi mentioned this pull request Jul 8, 2024
10 tasks
@julianwiedmann julianwiedmann added backport-done/1.16 The backport for Cilium 1.16.x for this PR is done. and removed backport-pending/1.16 labels Jul 12, 2024
@giorio94 giorio94 mentioned this pull request Jul 15, 2024
17 tasks
@github-actions github-actions bot added backport-done/1.15 The backport for Cilium 1.15.x for this PR is done. and removed backport-pending/1.15 labels Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-done/1.15 The backport for Cilium 1.15.x for this PR is done. backport-done/1.16 The backport for Cilium 1.16.x for this PR is done. kind/bug/CI This is a bug in the testing code. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact. sig/policy Impacts whether traffic is allowed or denied based on user-defined policies.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants