datapath: report distinct drop reason for missed endpoint policy tailcall#32151
Merged
kaworu merged 2 commits intocilium:mainfrom Apr 26, 2024
Merged
datapath: report distinct drop reason for missed endpoint policy tailcall#32151kaworu merged 2 commits intocilium:mainfrom
kaworu merged 2 commits intocilium:mainfrom
Conversation
Member
Author
|
/test |
Member
Author
|
The broader idea here is to isolate what kind of missed tailcall we're still seeing in CI, and make it possible to allow-list only Will probably have to backport for v1.15 as well to get reasonable CI feedback from the upgrade workflows. |
58ca733 to
287d399
Compare
Member
Author
|
/test |
This was referenced Apr 24, 2024
learnitall
approved these changes
Apr 25, 2024
Contributor
learnitall
left a comment
There was a problem hiding this comment.
API changes are good to go, thanks!
…call
Make it easier to differentiate between
(1) a missed program-internal tailcall (as reported by tail_call_internal())
that indicates a bug in how the agent loads the BPF program, and
(2) a missed tailcall to some endpoint's policy program, that can also
occur due to inherent race conditions for packets that are in-flight
while an endpoint is being terminated.
Signed-off-by: Julian Wiedmann <jwi@isovalent.com>
Ensure that the callers handle errors, and specify a more fine-grained drop reason. Signed-off-by: Julian Wiedmann <jwi@isovalent.com>
287d399 to
fb8562c
Compare
Member
Author
|
(rebase to resolve conflict in generated api) |
Member
Author
|
/test |
gentoo-root
approved these changes
Apr 26, 2024
This was referenced May 2, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improve the reporting of missed tailcalls for policy programs. While any missed tailcall in the program-internal flow (ie what's driven by
tail_call_internal()) points at a genuine loader bug, the policy tailcalls need to deal with race conditions due to eg terminating endpoints. Having distinct drop reasons makes it easier to diagnose the specific drop, and potentially allow-list them.