Skip to content

gateway: Sync up the experimental conformance test#31017

Merged
sayboras merged 1 commit intomainfrom
tam/fix-experiement-conformance-profile
Feb 28, 2024
Merged

gateway: Sync up the experimental conformance test#31017
sayboras merged 1 commit intomainfrom
tam/fix-experiement-conformance-profile

Conversation

@sayboras
Copy link
Copy Markdown
Member

@sayboras sayboras commented Feb 27, 2024

Description

This is to fix the below issue, which was missed in the PR #31005.

     experimental_conformance_test.go:117: error creating experimental conformance test suite: no kind is registered for the type v1.CustomResourceDefinitionList in scheme "k8s.io/client-go/kubernetes/scheme/register.go:80"
--- FAIL: TestExperimentalConformance (0.00s)

Fixes: #31005
Reported-by: Nate Sweet nathanjsweet@pm.me
Signed-off-by: Tam Mach tam.mach@cilium.io

Testing

Successful run can be found in https://github.com/cilium/cilium/actions/runs/8072297487

This is to fix the below issue, which was missed in the PR #31005.

```
     experimental_conformance_test.go:117: error creating experimental conformance test suite: no kind is registered for the type v1.CustomResourceDefinitionList in scheme "k8s.io/client-go/kubernetes/scheme/register.go:80"
--- FAIL: TestExperimentalConformance (0.00s)
```

Fixes: #31005
Signed-off-by: Tam Mach <tam.mach@cilium.io>
@maintainer-s-little-helper maintainer-s-little-helper Bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Feb 27, 2024
@sayboras sayboras force-pushed the tam/fix-experiement-conformance-profile branch from ae19d9a to c71b251 Compare February 27, 2024 22:34
@sayboras sayboras added the release-note/ci This PR makes changes to the CI. label Feb 27, 2024
@maintainer-s-little-helper maintainer-s-little-helper Bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Feb 27, 2024
@sayboras
Copy link
Copy Markdown
Member Author

/ci-gateway-api

@sayboras
Copy link
Copy Markdown
Member Author

/test

@sayboras sayboras marked this pull request as ready for review February 27, 2024 22:51
@sayboras sayboras requested a review from a team as a code owner February 27, 2024 22:51
@sayboras sayboras requested a review from meyskens February 27, 2024 22:51
@sayboras sayboras enabled auto-merge February 28, 2024 00:10
@sayboras sayboras added this pull request to the merge queue Feb 28, 2024
Merged via the queue into main with commit c59b409 Feb 28, 2024
@sayboras sayboras deleted the tam/fix-experiement-conformance-profile branch February 28, 2024 02:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature/k8s-gateway-api release-note/ci This PR makes changes to the CI.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants