clustermesh up/downgrade: test maxConnectedCluster#30446
Merged
Conversation
Contributor
Author
|
/test |
giorio94
reviewed
Jan 26, 2024
aanm
approved these changes
Jan 26, 2024
marseel
approved these changes
Jan 26, 2024
Member
marseel
left a comment
There was a problem hiding this comment.
LGTM, but pending unresolved Marco's comment
Configure the max-connected-clusters option for feature coverage in the ClusterMesh upgrade/downgrade tests. Previously, all clusters in the matrix were using the default value of 255. Now, 2 of the clusters will be configured to support up to 511 clusters. While we are not utilizing the full range of cluster IDs in the test, this feature changes the way identities are allocated and parsed. Enabling this will provide additional test coverage for this aspect. Signed-off-by: Tim Horner <timothy.horner@isovalent.com>
613352b to
319bf88
Compare
Contributor
Author
|
/test |
giorio94
approved these changes
Jan 26, 2024
tklauser
approved these changes
Jan 30, 2024
Contributor
Author
|
/ci-gateway-api |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Configure the max-connected-clusters option for feature coverage in the ClusterMesh upgrade/downgrade tests.
Previously, all clusters in the matrix were using the default value of
255. Now, 2 of the clusters will be configured to support up to 511 clusters. While we are not utilizing the full range of cluster IDs in the test, this feature changes the way identities are allocated and parsed. Enabling this will provide additional test coverage for this aspect.