Split mapstate keys into allow and deny#28352
Merged
joamaki merged 3 commits intocilium:mainfrom Oct 6, 2023
Merged
Conversation
714daaa to
2fb53b8
Compare
joamaki
reviewed
Oct 2, 2023
joamaki
reviewed
Oct 2, 2023
joamaki
reviewed
Oct 2, 2023
joamaki
reviewed
Oct 2, 2023
Member
Author
|
/test |
4bd82fd to
7e771e7
Compare
Member
Author
|
/test |
7e771e7 to
477f805
Compare
Member
Author
|
/ci-ginkgo |
Member
Author
|
/test |
Member
Author
|
/ci-gateway-api Rerunning. Filed #28374 for the issue which occurred. |
1 task
Member
|
@bimmlerd Changed v1.12 backport label to needs-backport/1.12 to be able to complete the release process. Looks like we can't have any pending backports when doing the release. |
Member
|
@bimmlerd Added backport/author label because I assume you'll take care of manually backporting this. Automated backports are leading to merge conflicts. |
This was referenced Oct 31, 2023
Member
Author
|
removing backport-pending labels here, as the project has decided against backporting this change -- it's too invasive for extensive backporting. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The first commit converts the MapState type from a newtype an interface (mostly Nate's work, rebased on newer
main)The second commit then splits the map in the struct into two - to track allows and denies seperately.
This allows for an optimization in the third commit:
denyPreferredInsertsfor the allow case, now doesn't have to loop through all other allows (which we don't care about).Commit msgs for convenience:
policy: Make MapState an interfacemapstate: split allows and deniesmapstate: optimize denyPreferredInsert