Skip to content

gha: Increase Ingress status wait time#26219

Merged
aanm merged 1 commit intocilium:mainfrom
sayboras:tam/ingress-flake
Jun 15, 2023
Merged

gha: Increase Ingress status wait time#26219
aanm merged 1 commit intocilium:mainfrom
sayboras:tam/ingress-flake

Conversation

@sayboras
Copy link
Copy Markdown
Member

@sayboras sayboras commented Jun 14, 2023 •
edited
Loading

Description

The current value is set as 10s, which might not be enough for a small kind cluster in CI environment, hence timeout happened as per below. This commit is to increase the max wait time to 60s to mitigate the issue.

  Scenario: An Ingress with a trailing slashes in a prefix path rule should ignore the trailing slash and send traffic to the matching backend service # features/path_rules.feature:181
    Then The Ingress status shows the IP address or FQDN where it is exposed # features/path_rules.feature:93
      Error: waiting for ingress status update: timed out waiting for the condition

Fixes: #25040

Testing

Testing was done by re-running ingress conformance tests for 4x9 times.

https://github.com/cilium/cilium/actions/runs/5265957417

#!/bin/bash
for i in {1..8}
do
  now=$(date +"%T")
  echo "$now: Re-run the job $i times"
  gh run rerun 5265957417
  sleep 25m
done

@sayboras
gha: Increase Ingress status wait time
9000376 
The current value is set as 10s, which might not be enough for a small
kind cluster in CI environment, hence timeout happened as per below.

This commit is to increase max wait time to 60s to mitigate the issue.

```
  Scenario: An Ingress with a trailing slashes in a prefix path rule should ignore the trailing slash and send traffic to the matching backend service # features/path_rules.feature:181
    Then The Ingress status shows the IP address or FQDN where it is exposed # features/path_rules.feature:93
      Error: waiting for ingress status update: timed out waiting for the condition
```

Fixes: cilium#25040
Signed-off-by: Tam Mach <tam.mach@cilium.io>
@maintainer-s-little-helper maintainer-s-little-helper Bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jun 14, 2023
@sayboras sayboras added release-note/ci This PR makes changes to the CI. area/servicemesh GH issues or PRs regarding servicemesh feature/k8s-ingress labels Jun 14, 2023
@maintainer-s-little-helper maintainer-s-little-helper Bot removed dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. labels Jun 14, 2023
@sayboras sayboras marked this pull request as ready for review June 14, 2023 11:58
@sayboras sayboras requested review from a team as code owners June 14, 2023 11:58
@sayboras sayboras requested a review from brlbil June 14, 2023 11:58
@aspsk aspsk self-requested a review June 15, 2023 07:05
@sayboras sayboras added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Jun 15, 2023
@sayboras
Copy link
Copy Markdown
Member Author

sayboras commented Jun 15, 2023

Required reviews are in, full CI is not required, marking this ready to merge 👍

@aanm aanm merged commit 44364e7 into cilium:main Jun 15, 2023
@sayboras sayboras deleted the tam/ingress-flake branch June 18, 2023 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brlbil brlbil brlbil approved these changes

@aspsk aspsk aspsk approved these changes

Assignees

No one assigned

Labels

area/servicemesh GH issues or PRs regarding servicemesh feature/k8s-ingress ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/ci This PR makes changes to the CI.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

CI: ingress-conformance-test "An Ingress with a trailing slashes in a prefix path rule..."

4 participants

@sayboras @brlbil @aspsk @aanm