[WIP] Test upgrade#25946
Conversation
Signed-off-by: Martynas Pumputis <m@lambda.lt>
Signed-off-by: Zhichuan Liang <gray.liang@isovalent.com>
|
/ci-e2e |
Signed-off-by: Zhichuan Liang <gray.liang@isovalent.com>
Signed-off-by: gray <gray.liang@isovalent.com>
|
/ci-e2e |
| echo ">>>>>>>>>> $STALE_IP6_HOST" | ||
| if [ "$STALE_IP6_HOST" != "<nil>" ]; then | ||
| ip -6 addr del $STALE_IP6_HOST dev $HOST_DEV1 | ||
| fi |
There was a problem hiding this comment.
@brb Martynas, we can either delete the stale ipv6 here at init.sh or (see the other comment below)
| args[initArgStaleIPv6NodeIP] = addr.IPNet.IP.String() | ||
| break | ||
| } | ||
| } |
There was a problem hiding this comment.
Or we delete the stale ipv6 here, when we generate the new ipv6 for cilium_host.
Which one do you prefer? For me, deleting stale ipv6 at init.sh seems to be more cohesive, as that will be the only place we change the cilium_host's ipv6, but we have to pass an additional shell argument.
(There are other options, like deleting when installing ipv6 routes, but that's way too in-cohesive, so I ditched those ideas.)
There was a problem hiding this comment.
As we are migrating from bpf/init.sh, I'd suggest to delete it here.
Signed-off-by: gray <gray.liang@isovalent.com>
|
/ci-e2e |
|
/ci-e2e |
Signed-off-by: gray <gray.liang@isovalent.com>
3849865 to
774d255
Compare
|
/ci-e2e |
|
Cilium Conformance E2E turns green, it appears our patch from #25962 is working. |
Fixes: #issue-number