Fix connectivity issue if nodes share the same name across the clustermesh and wireguard is enabled#24785
Merged
ldelossa merged 1 commit intocilium:mainfrom Apr 20, 2023
Conversation
3fea3e9 to
e03cff2
Compare
Member
Author
|
/test |
Member
Author
|
/ci-eks Hit unrelated flake #24774 |
Member
Author
|
The ConformanceEKS test hit again the same unrelated flake. I'm not rerunning it, since it wouldn't test anything wireguard-related in any case. |
YutaroHayakawa
approved these changes
Apr 18, 2023
Currently, the wireguard subsystem in the cilium agent caches information about the known peers by node name only. This can lead to conflicts in case of clustermesh, if nodes in different clusters have the same name, causing in turn connectivity issues. Hence, let's switch to identify peers by full name (i.e., cluster-name/node-name) to ensure uniqueness. This modification does not introduce issues during upgrades, since the node ID is not propagated to the datapath. Fixes: cilium#24227 Reported-by: @oulinbao <oulinbao@163.com> Signed-off-by: Marco Iorio <marco.iorio@isovalent.com>
e03cff2 to
296fc49
Compare
Member
Author
|
/test Job 'Cilium-PR-K8s-1.26-kernel-net-next' failed: Click to show.Test NameFailure OutputJenkins URL: https://jenkins.cilium.io/job/Cilium-PR-K8s-1.26-kernel-net-next/1895/ If it is a flake and a GitHub issue doesn't already exist to track it, comment |
Member
Author
|
k8s-1.26-kernel-net-next hit unrelated flake: #22578 (comment) |
Member
Author
|
/test-1.25-5.4 |
Member
Author
|
/test-1.26-4.19 |
Member
Author
|
/test-1.27-net-next |
Member
Author
|
test-1.27-net-next failures:
|
Member
Author
|
Marking as ready to merge, since reviews are in, and test failures are due to known flakes (and unrelated, as wireguard is not enabled). |
4 tasks
7 tasks
15 tasks
8 tasks
This was referenced May 12, 2023
This was referenced May 16, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the wireguard subsystem in the cilium agent caches information about the known peers by node name only. This can lead to conflicts in case of clustermesh, if nodes in different clusters have the same name, causing in turn connectivity issues. Hence, let's switch to identify peers by full name (i.e., cluster-name/node-name) to ensure uniqueness.
Fixes: #24227
Reported-by: @oulinbao