datapath/linux/route: fix CI expectations for rule string format#24577
Merged
julianwiedmann merged 1 commit intomasterfrom Mar 27, 2023
Merged
datapath/linux/route: fix CI expectations for rule string format#24577julianwiedmann merged 1 commit intomasterfrom
julianwiedmann merged 1 commit intomasterfrom
Conversation
When CI is running it expects the fib rule format without the new protocol, so it breaks when matching the string formats with the expected ones. Fix it by adding the protocol. Fixes: d0cca9d ("datapath/linux/route: add support for rule protocol") Signed-off-by: Nikolay Aleksandrov <nikolay@isovalent.com>
pchaigno
approved these changes
Mar 27, 2023
pchaigno
approved these changes
Mar 27, 2023
Member
|
I believe this can be merged without running the full CI as the changes are very limited in scope and they fix a CI job that is currently consistently failing. Marking ready to merge. |
7 tasks
Member
|
I've added the backport label for v1.13 here given the PR is fixes is planned for backport into 1.13. |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When CI is running it expects the fib rule format without the new protocol, so it breaks when matching the string formats with the expected ones. Fix it by adding the protocol.
Fixes: d0cca9d ("datapath/linux/route: add support for rule protocol")