Revert "allocator: fix out-of-valid-range identities being allocated"#18808
Merged
jibi merged 1 commit intocilium:masterfrom Feb 16, 2022
Merged
Revert "allocator: fix out-of-valid-range identities being allocated"#18808jibi merged 1 commit intocilium:masterfrom
jibi merged 1 commit intocilium:masterfrom
Conversation
This reverts commit 5224f69. This commit consistently broke the Multicluster workflow on master. We probably merged a bit quickly because the Multicluster workflow wasn't marked as Required and was very flaky until recently. Signed-off-by: Paul Chaignon <paul@cilium.io>
tklauser
approved these changes
Feb 15, 2022
sayboras
approved these changes
Feb 15, 2022
jibi
approved these changes
Feb 15, 2022
Member
Author
|
/test |
Member
Author
|
Hit a timeout pulling Docker images. |
Contributor
|
Hi @pchaigno sorry for the broken, will the Multicluster workflow be marked as required in the next? Or are there other ways that I can find multi-cluster related breakages more timely. |
Member
Author
|
@ArthurChiao We've marked the workflow required. |
Member
Author
|
Two failures. Rerunning to check if they are indeed flakes: https://jenkins.cilium.io/job/Cilium-PR-K8s-1.21-kernel-5.4/518/. |
Merged
Member
Author
|
Tests are passing, we have several reviews, and this is fixing CI on master. So I marked ready to merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts pull request #18151.
This commit consistently broke the Multicluster workflow on master. We probably merged a bit quickly because the Multicluster workflow wasn't marked as Required and was very flaky until recently.
cc @ArthurChiao