cocci: New test to find missing identity_is_{remote_,}node#18385
Merged
pchaigno merged 1 commit intocilium:masterfrom Jan 12, 2022
Merged
cocci: New test to find missing identity_is_{remote_,}node#18385pchaigno merged 1 commit intocilium:masterfrom
identity_is_{remote_,}node#18385pchaigno merged 1 commit intocilium:masterfrom
Conversation
This new Coccinelle script finds and replaces missing calls to helper functions identity_is_node and identity_is_remote_node. These functions were introduced in commit 7021861 ("bpf: Refactor node identity checking") to prepare for the addition of KUBE_APISERVER_NODE_ID, which also corresponds to a remote node identity. The script is a bit more covoluted than ideally should be, because I haven't found a succinct way to tell Coccinelle that "e != HOST_ID && e != REMOTE_NODE_ID" is semantically equivalent to "e != REMOTE_NODE_ID && e != HOST_ID", so we have to enumerate both cases. This was tested by reverting some of the changes introduced in commit 7021861 ("bpf: Refactor node identity checking"). Signed-off-by: Paul Chaignon <paul@cilium.io>
borkmann
approved these changes
Jan 12, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This new Coccinelle script finds and replaces missing calls to helper functions
identity_is_nodeandidentity_is_remote_node. These functions were introduced in commit 7021861 ("bpf: Refactor node identity checking") to prepare for the addition ofKUBE_APISERVER_NODE_ID, which also corresponds to a remote node identity.The script is a bit more convoluted than ideally should be, because I haven't found a succinct way to tell Coccinelle that
e != HOST_ID && e != REMOTE_NODE_IDis semantically equivalent toe != REMOTE_NODE_ID && e != HOST_ID, so we have to enumerate both cases.This was tested by reverting some of the changes introduced in commit 7021861 ("bpf: Refactor node identity checking").