vagrant: Bump all Vagrant box versions#17391
Closed
twpayne wants to merge 1 commit intocilium:masterfrom
twpayne:pr/update-packer-ci-build
Closed
vagrant: Bump all Vagrant box versions#17391twpayne wants to merge 1 commit intocilium:masterfrom twpayne:pr/update-packer-ci-build
twpayne wants to merge 1 commit intocilium:masterfrom
twpayne:pr/update-packer-ci-build
Conversation
Signed-off-by: Tom Payne <tom@isovalent.com>
qmonnet
approved these changes
Sep 14, 2021
gandro
requested changes
Sep 14, 2021
| new box is built and tested. | ||
|
|
||
| Once you change the image versions locally, create a branch named | ||
| ``pr/update-packer-ci-build`` and open a PR ``github.com/cilium/cilium``. |
Member
There was a problem hiding this comment.
The PR itself is fine, but to ensure correct caching in Jenkins, the branch for such commits must be named pr/update-packer-ci-build on github.com/cilium/cilium, not on a fork. We probably should update the docs to make that more clear, now that most users use their own forks for development.
Member
|
This looks like a duplicate of #17352 to me, apart from the versions being bumped by 2 instead of 1. Were there any changes in the packer-ci repo between these two build runs? |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Tom Payne tom@isovalent.com
Vagrant box builds on Jenkins have all completed successfully, see https://jenkins.cilium.io/.
This is needed before #17322 can be merged.