Closed
Conversation
5 tasks
e6722c2 to
c9570ce
Compare
This commit adds a thorough test on handle_ipv4_from_lxc based on our ebpf unit testing framework. Signed-off-by: Xinyuan Zhang <zhangxinyuan@google.com>
c9570ce to
e988625
Compare
Contributor
|
The approach in this PR is similar to #17227, were an alternative approach is investigated. Moving this PR into draft mode until the investigation concludes. |
Member
|
We recently added the BPF unit testing framework - https://docs.cilium.io/en/latest/contributing/testing/bpf/. The proposed mocking no longer is needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds tests for bpf_lxc.c. The first commit contains a test on handle_ipv4_from_lxc, and I am going to wrtite tests for the other functions in the next commits. The test covers nearly every line of the function.
Signed-off-by: Xinyuan Zhang zhangxinyuan@google.com