Conversation
190daaf to
24307fe
Compare
Signed-off-by: Tobias Klauser <tobias@cilium.io>
Bump the go version in go.mod to 1.17. This will change the module graph to include only the immediate dependencies of other go 1.17 modules, not their full transitive dependencies. As a consequence of this, the newly-added requirements on indirect dependencies are added by `go mod tidy` in a separate require block. See https://golang.org/doc/go1.17#graph-pruning and https://golang.org/ref/mod#graph-pruning for details. Signed-off-by: Tobias Klauser <tobias@cilium.io>
24307fe to
5396672
Compare
Starting with Go 1.17, `//go:build` lines are preferred over `// +build` lines, see https://golang.org/doc/go1.17#build-lines and https://golang.org/design/draft-gobuild for details. This change was generated by running Go 1.17 `gofmt -w .` which automatically adds `//go:build` lines based on the existing `// +build` lines. Signed-off-by: Tobias Klauser <tobias@cilium.io>
Member
Author
|
test-me-please |
aanm
approved these changes
Aug 19, 2021
Member
aanm
left a comment
There was a problem hiding this comment.
How many teams do you want to request review?
Yes
😄
nebril
approved these changes
Aug 20, 2021
pchaigno
approved these changes
Aug 20, 2021
kkourt
approved these changes
Aug 20, 2021
Member
Author
|
Received 4 reviews from teams covering the most important aspects of the change (@cilium/build, @cilium/ci-structure and @cilium/vendor). The other groups were requested due to the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First commit updates the Go version for Cilium build and updates the Docker images.
Second commit changes
go.modtogo 1.17to use the new module graph pruning, see https://golang.org/doc/go1.17#graph-pruningThird commit adds
//go:buildlines in addition to existing//+buildlines, as automatically done bygofmtin Go 1.17. Note that also some files generated bydeepcopy-genwere changed. These changes will be lost on the next update until we update to a version ofdeepcopy-genwhich includes kubernetes-sigs/controller-tools#595.