Conversation
Member
Author
|
Created #1626 to track this. |
75b7d94 introduced a regression because it piped the debug output of the tests to `tee`, which masks the return code of the test running for the K8s tests. This means that a test could fail, but the end result of piping to `tee` has a return code of zero, meaning the build thinks the tests passed just fine. This is a serious regression in the CI. Before running the K8s tests, `set -o pipefail` which will cause the error code to get propagated up to the calling script of the tests. Signed-off by: Ian Vernon <ian@cilium.io>
e6136c1 to
b408447
Compare
Member
Author
|
The fact that this patch failed during one of the builds of the K8s tests shows that it should be merged: link. |
ianvernon
commented
Sep 29, 2017
| # Test 18: check policy enforcement after malformed policy is created and deleted | ||
| # All endpoints should have policy enforcement enabled | ||
| log " Test 18: check policy enforcement after malformed policy is created and deleted. All endpoints should have policy enforcement enabled" | ||
| set +e |
Member
Author
There was a problem hiding this comment.
We expect this addition of malformed policy to fail, so we don't want the test to fail when we try to add it.
tgraf
approved these changes
Sep 29, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
commit 75b7d94 introduced a regression because it piped the debug output of the tests to
tee, which masks the return code of the test running for the K8s tests. This means that a test could fail, but the end result of piping toteehas a return code of zero, meaning the build thinks the tests passed just fine. This is a serious regression in the CI. Before running the tests,set -o pipefailwhich will cause the error code to get propagated up to the calling script from the tests.Signed-off by: Ian Vernon ian@cilium.io
Fixes: #1626