Conversation
|
@aanm Yes I think that makes sense, as we already do for all other cloud providers. |
|
Just to synchronize with the discussion we had during the 2021-03-29 Cilium community meeting, we discussed that there is some degree of overlap between the common portions of the EKS, AKS and AlibabaCloud operator code. As a medium to long-term goal, we would all like to improve code reuse between these implementations where it makes sense, to minimize ongoing maintenance burden (and minimize the likelihoood of needing to fix a bug multiple times across the implementations). That said, it doesn't seem reasonable to place that entire burden of addressing tech debt onto @l1b0k. We discussed that we should narrow down the remaining review feedback and make sure it's addressed, then when we're happy with the implementation, merge it and mark it as a "beta" feature for the initial v1.10 release. Follow up items after merging this PR would be to investigate any documentation (and/or Cilium CLI implementations), plus consider how regression testing will work for this new feature. During v1.11 release cycle we can further explore these questions and with more user feedback, evaluate marking the feature as stable in the documentation. |
aanm
left a comment
There was a problem hiding this comment.
@l1b0k thanks for the changes, since we are about to add the alibaba operator image, please also make appropariate changes in .github/workflows/images-legacy-releases.yaml, .github/workflows/images-legacy.yaml
and .github/workflows/images-legacy-hotfix-releases.yaml
|
The docker image repository for |
Signed-off-by: l1b0k <libokang.dev@gmail.com>
Signed-off-by: l1b0k <libokang.dev@gmail.com>
joestringer
left a comment
There was a problem hiding this comment.
New GitHub workflow bits look trivially correct to me, @aanm did you want to take another look?
|
test-me-please |
|
@l1b0k there are some real failures detected by the CI here: https://github.com/cilium/cilium/pull/15160/checks?check_run_id=2250623707 |
christarazi
left a comment
There was a problem hiding this comment.
LGTM thanks. Only thing left is to address the issues caught by CI and this PR should be good to go.
|
test-me-please |
The AlibabaCloud allocator is specific to Cilium deployments running in the AlibabaCloud and performs IP allocation based on IPs of ENI. More for ENI https://www.alibabacloud.com/help/doc-detail/58496.htm Signed-off-by: l1b0k <libokang.dev@gmail.com>
|
test-me-please |
|
closing and re-opening for travis to kick in |
|
Travis is not collaborating... If it breaks on master we can always revert. Thank you for this contribution @l1b0k! 🎉 |
Hi, maintainers , this pr provide an AlibabaCloud Operator.
This allow Cilium deployments running in the AlibabaCloud and performs IP allocation based on IPs of ENI.