Skip to content

[v1.7] test: Replace managed etcd test with generic etcd test#13574

Merged
aanm merged 5 commits intocilium:v1.7from
christarazi:pr/christarazi/1.7-replace-managed-etcd-test
Oct 20, 2020
Merged

[v1.7] test: Replace managed etcd test with generic etcd test#13574
aanm merged 5 commits intocilium:v1.7from
christarazi:pr/christarazi/1.7-replace-managed-etcd-test

Conversation

@christarazi
Copy link
Copy Markdown
Member

@christarazi christarazi commented Oct 14, 2020 •
edited
Loading

Direct backport of #11544. The first 2 commits are a backport, and other commits are direct commits (considering applying them to v1.8 & master).

Fixes: #13282

Once this PR is merged, you can update the PR labels via:

$ for pr in 11544; do contrib/backporting/set-labels.py $pr done 1.7; done

@christarazi christarazi requested a review from a team as a code owner October 14, 2020 22:29
@christarazi christarazi added area/CI Continuous Integration testing issue or flake release-note/ci This PR makes changes to the CI. labels Oct 14, 2020
@maintainer-s-little-helper maintainer-s-little-helper Bot added backport/1.7 kind/backports This PR provides functionality previously merged into master. labels Oct 14, 2020
@christarazi christarazi force-pushed the pr/christarazi/1.7-replace-managed-etcd-test branch from c2b02de to 264eeaf Compare October 14, 2020 22:32
@christarazi christarazi requested a review from tgraf October 14, 2020 22:32
@christarazi
Copy link
Copy Markdown
Member Author

christarazi commented Oct 14, 2020

test-backport-1.7

@christarazi
Copy link
Copy Markdown
Member Author

christarazi commented Oct 15, 2020

test-focus K8sDatapathConfig.*Etcd

tgraf added 2 commits October 15, 2020 00:18
@tgraf @christarazi
test: Replace managed etcd test with etcd test
10840bb 
[ upstream commit bf3a6c5 ]

[ Backporter's notes: The deployment manager code doesn't exist in v1.7,
                      so that was omitted in this backport commit. The
                      functional changes that the deployment manager
                      provided were translated for the current code in
                      v1.7. Also, "synchronizeK8sNodes" is not under the
                      "config" Helm subchart in v1.7, but rather under
                      "operator". ]

The managed etcd feature is being deprecated soon. The test has been
unreliable due to etcd operator not being able to bring up etcd clusters
reliably. We want to ensure test coverage for the etcd backing though.
Convert the managed etcd test to a more generic test which uses
stateless etcd for a reliable outcome.

Fixes: cilium#11181

Signed-off-by: Thomas Graf <thomas@cilium.io>
Signed-off-by: Chris Tarazi <chris@isovalent.com>
@tgraf @christarazi
test: Remove leftover etcd operator related code
60ba33f 
[ upstream commit 43a7bba ]

Signed-off-by: Thomas Graf <thomas@cilium.io>
Signed-off-by: Chris Tarazi <chris@isovalent.com>
@christarazi christarazi force-pushed the pr/christarazi/1.7-replace-managed-etcd-test branch from 264eeaf to 60ba33f Compare October 15, 2020 07:19
@christarazi
Copy link
Copy Markdown
Member Author

christarazi commented Oct 15, 2020

test-focus K8sDatapathConfig.*Etcd

@nebril
Copy link
Copy Markdown
Member

nebril commented Oct 15, 2020

Looks like Cilium pods are failing because of

2020-10-15T08:13:30.501124813Z level=fatal msg="Timeout while waiting for initial allocator state" subsys=allocator

@aanm
Copy link
Copy Markdown
Member

aanm commented Oct 15, 2020

@gandro do you think that failure will be fixed by #13514? or it's not even related?

@christarazi
Copy link
Copy Markdown
Member Author

christarazi commented Oct 15, 2020 •
edited
Loading

Looks like Cilium pods are failing because of

2020-10-15T08:13:30.501124813Z level=fatal msg="Timeout while waiting for initial allocator state" subsys=allocator

I am not able to reproduce this locally.

@christarazi
Copy link
Copy Markdown
Member Author

christarazi commented Oct 15, 2020

test-focus K8sDatapathConfig.*Etcd

@christarazi
Copy link
Copy Markdown
Member Author

christarazi commented Oct 15, 2020 •
edited
Loading

test-me-please

Edit: oops wrong command

@christarazi
Copy link
Copy Markdown
Member Author

christarazi commented Oct 15, 2020

test-backport-1.7

@christarazi christarazi force-pushed the pr/christarazi/1.7-replace-managed-etcd-test branch from 703d17f to adfc5bc Compare October 16, 2020 06:48
@christarazi
Copy link
Copy Markdown
Member Author

christarazi commented Oct 16, 2020 •
edited
Loading

test-backport-1.7

Edit: passed!

@christarazi
test: Avoid reinstalling Cilium after test suite
7d245d2 
This commit removes an unnecessary step which installs Cilium after
every Context block in this test suite. It is unnecessary because each
Context will install Cilium and configure it accordingly. This will also
speed up the test suite execution time.

Signed-off-by: Chris Tarazi <chris@isovalent.com>
@christarazi christarazi force-pushed the pr/christarazi/1.7-replace-managed-etcd-test branch from adfc5bc to 6f0596e Compare October 16, 2020 17:17
@christarazi
test: Refactor DatapathConfiguration etcd test
6a61931 
This commit separates out the preamble of deploying etcd and
reconfiguring Cilium to use it into a BeforeEach. This improves the
readability of the test.

Signed-off-by: Chris Tarazi <chris@isovalent.com>
@christarazi
test: Clean up etcd-deployment after test
7b45530 
Signed-off-by: Chris Tarazi <chris@isovalent.com>
@christarazi christarazi force-pushed the pr/christarazi/1.7-replace-managed-etcd-test branch from 6f0596e to 7b45530 Compare October 16, 2020 17:26
@christarazi
Copy link
Copy Markdown
Member Author

christarazi commented Oct 16, 2020 •
edited
Loading

test-backport-1.7

Edit: two passes in a row!

@christarazi
Copy link
Copy Markdown
Member Author

christarazi commented Oct 16, 2020 •
edited
Loading

test-backport-1.7

Edit: 3 passes in a row!

@christarazi christarazi linked an issue Oct 16, 2020 that may be closed by this pull request
CI: v1.7: "K8sDatapathConfig ManagedEtcd Check connectivity with managed etcd" backport needed #13282
Closed
@christarazi
Copy link
Copy Markdown
Member Author

christarazi commented Oct 18, 2020 •
edited
Loading

test-backport-1.7

Edit: 4 passes in a row!

@christarazi
Copy link
Copy Markdown
Member Author

christarazi commented Oct 19, 2020 •
edited
Loading

test-backport-1.7

Edit: 5 passes in a row!

@christarazi
Copy link
Copy Markdown
Member Author

christarazi commented Oct 19, 2020 •
edited
Loading

test-backport-1.7

Edit: 6 passes in a row! (Cilium-Ginkgo-Test-k8s failed to provision)

@gandro
Copy link
Copy Markdown
Member

gandro commented Oct 19, 2020

@gandro do you think that failure will be fixed by #13514? or it's not even related?

Sorry for the late response. I don't think it's related (the above timeout happens in NewAllocator, I don't see how that would be impacted by the checks in lookup).

@nebril
Copy link
Copy Markdown
Member

nebril commented Oct 19, 2020

test-missed-k8s

@aanm aanm merged commit 8603523 into cilium:v1.7 Oct 20, 2020
@christarazi christarazi deleted the pr/christarazi/1.7-replace-managed-etcd-test branch October 20, 2020 17:42
@christarazi christarazi mentioned this pull request Oct 20, 2020
Closed
@christarazi christarazi mentioned this pull request Oct 28, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nebril nebril nebril approved these changes

@pchaigno pchaigno pchaigno approved these changes

@aanm aanm aanm approved these changes

@tgraf tgraf Awaiting requested review from tgraf

Assignees

No one assigned

Labels

area/CI Continuous Integration testing issue or flake kind/backports This PR provides functionality previously merged into master. release-note/ci This PR makes changes to the CI.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

CI: v1.7: "K8sDatapathConfig ManagedEtcd Check connectivity with managed etcd" backport needed

6 participants

@christarazi @nebril @aanm @gandro @pchaigno @tgraf