Skip to content

test: Increase timeout for waiting LB IP addr on GKE#13557

Merged
nebril merged 1 commit intomasterfrom
pr/brb/ci-inc-lb-timeout
Oct 14, 2020
Merged

test: Increase timeout for waiting LB IP addr on GKE#13557
nebril merged 1 commit intomasterfrom
pr/brb/ci-inc-lb-timeout

Conversation

@brb
Copy link
Copy Markdown
Member

@brb brb commented Oct 14, 2020

Recently, the test case which waits for LB IP addr started to fail:

github.com/cilium/cilium/test/ginkgo-ext/scopes.go:514
Cannot retrieve loadbalancer IP for test-lb
Expected
<*errors.errorString | 0xc000324af0>: {
    s: "could not get service LoadBalancer IP addr: 30s timeout expired",
}
to be nil
github.com/cilium/cilium/test/k8sT/Services.go:920

This happens because on GKE we use GCP LB which provisioning might take longer
than 30s. For now, let's increase the timeout. If it doesn't help, we can
always rely on dummy-lb instead.

Fix #13554

Recently, the test case which waits for LB IP addr started to fail:

    github.com/cilium/cilium/test/ginkgo-ext/scopes.go:514
    Cannot retrieve loadbalancer IP for test-lb
    Expected
	<*errors.errorString | 0xc000324af0>: {
	    s: "could not get service LoadBalancer IP addr: 30s timeout expired",
	}
    to be nil
    github.com/cilium/cilium/test/k8sT/Services.go:920

This happens because on GKE we use GCP LB which provisioning might take longer
than 30s. For now, let's increase the timeout. If it doesn't help, we can
always install dummy-lb instead.

Signed-off-by: Martynas Pumputis <m@lambda.lt>
@brb brb added pending-review area/CI Continuous Integration testing issue or flake release-note/ci This PR makes changes to the CI. labels Oct 14, 2020
@brb brb requested a review from a team as a code owner October 14, 2020 10:33
@brb
Copy link
Copy Markdown
Member Author

brb commented Oct 14, 2020

retest-gke

@nebril
Copy link
Copy Markdown
Member

nebril commented Oct 14, 2020

gke tests, which were affected, passed. this won't affect other builds, will merge soon

@nebril nebril merged commit bab1ea2 into master Oct 14, 2020
@nebril nebril deleted the pr/brb/ci-inc-lb-timeout branch October 14, 2020 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/CI Continuous Integration testing issue or flake release-note/ci This PR makes changes to the CI.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CI: GKE: K8sServicesTest Checks service across nodes Tests NodePort (kube-proxy)

3 participants