lbmap: Sort backends before creating maglev lookup table#13461
Merged
lbmap: Sort backends before creating maglev lookup table#13461
Conversation
Member
Author
|
retest-net-next |
pchaigno
approved these changes
Oct 8, 2020
borkmann
approved these changes
Oct 8, 2020
8bea8d2 to
3b3bf09
Compare
Member
Author
|
retest-net-next |
pchaigno
reviewed
Oct 8, 2020
3b3bf09 to
6366c82
Compare
Member
Author
|
retest-net-next |
Maglev algorithm might produce different lookup table for the same set of backends when they are listed in a different order. To avoid that sort backends by name, because the names are the same on all nodes, while IDs are not. Fix: 51605b6 ("Add pkg/maglev") Signed-off-by: Martynas Pumputis <m@lambda.lt>
Member
Author
|
retest-4.19 |
Member
Author
|
retest-runtime |
aanm
approved these changes
Oct 8, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Maglev algorithm might produce different lookup table for the same set of backends when they are listed in a different order. To avoid that sort backends by name, because the names are the same on all nodes, while IDs are not.
Fix: 51605b6 ("Add pkg/maglev")
Fixes: #13224