Skip to content

docs: Add note for users upgrading K8s#13273

Merged
aanm merged 1 commit intocilium:masterfrom
christarazi:pr/christarazi/update-k8s-upgrade-docs
Sep 25, 2020
Merged

docs: Add note for users upgrading K8s#13273
aanm merged 1 commit intocilium:masterfrom
christarazi:pr/christarazi/update-k8s-upgrade-docs

Conversation

@christarazi
Copy link
Copy Markdown
Member

Updates: #12737

@christarazi christarazi requested a review from a team as a code owner September 23, 2020 23:04
@christarazi christarazi added area/k8s Impacts the kubernetes API, or kubernetes -> cilium internals translation layers. release-note/misc This PR makes changes that have no direct user impact. labels Sep 23, 2020
@maintainer-s-little-helper maintainer-s-little-helper Bot added dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. and removed dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. labels Sep 23, 2020
@christarazi christarazi requested a review from aanm September 23, 2020 23:10
Comment thread Documentation/install/upgrade.rst Outdated
Comment on lines 335 to 339
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd usually expect (and for that matter, encourage) separate upgrades of Cilium vs. Kubernetes. At a glance I found this a bit ambiguous as to whether this is a step we're trying to say users should run during Cilium upgrade or trying to give them a heads up if they're upgrading K8s...?

Maybe splitting out into a few questions:

  • Do users on K8s 1.16 or higher have to take any action?
  • Do users on k8s 1.15 or lower have to take any action?
  • Is this action required during Cilium 1.9 upgrade?
  • Is this action required during K8s version upgrade?

Copy link
Copy Markdown
Member Author

@christarazi christarazi Sep 24, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To answer your questions, users do not have to take any additional action if they are keeping their K8s version the same all users should run the preflight checker before upgrading. See @aanm's note below. Updating to address his review.

Comment thread Documentation/install/upgrade.rst Outdated
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Users who are upgrading
from Kubernetes below v1.16.0 to past Kubernetes v1.16.0, while running
Cilium v1.9 or greater, should run the pre-flight checker mentioned above.
The pre-flight check will ensure the custom resources installed inside the
cluster are well-formed.

this whole section can be removed. When performing the upgrade, users should run the pre-flight build regardless of the information is written here.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a good point. We don't really need the extra contraints. We should detect badly formed CRDs regardless of K8s version.

@christarazi christarazi force-pushed the pr/christarazi/update-k8s-upgrade-docs branch from 4fc95d9 to 0c261ab Compare September 24, 2020 17:12
Comment thread Documentation/install/upgrade.rst Outdated
Updates: cilium#12737

Signed-off-by: Chris Tarazi <chris@isovalent.com>
@christarazi christarazi force-pushed the pr/christarazi/update-k8s-upgrade-docs branch from 0c261ab to 96e49b3 Compare September 24, 2020 21:59
@aanm aanm merged commit a07c651 into cilium:master Sep 25, 2020
@christarazi christarazi deleted the pr/christarazi/update-k8s-upgrade-docs branch September 25, 2020 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/k8s Impacts the kubernetes API, or kubernetes -> cilium internals translation layers. release-note/misc This PR makes changes that have no direct user impact.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants