Skip to content

k8s: Remove CRD deleting functionality#13272

Merged
qmonnet merged 1 commit intocilium:masterfrom
christarazi:pr/christarazi/remove-delete-crd
Sep 24, 2020
Merged

k8s: Remove CRD deleting functionality#13272
qmonnet merged 1 commit intocilium:masterfrom
christarazi:pr/christarazi/remove-delete-crd

Conversation

@christarazi
Copy link
Copy Markdown
Member

@christarazi christarazi commented Sep 23, 2020 •
edited
Loading

This commit removes the ability to delete CRDs from Cilium because that
would delete all the CRs in the cluster.

Follow-up from:
#11477 (comment)

Updates: #12737

Prevent Cilium from deleting all custom resources especially CNP & CCNP installed inside the cluster

@christarazi christarazi requested a review from a team as a code owner September 23, 2020 22:47
@christarazi christarazi requested a review from a team September 23, 2020 22:47
@christarazi christarazi added area/k8s Impacts the kubernetes API, or kubernetes -> cilium internals translation layers. needs-backport/1.6 release-note/misc This PR makes changes that have no direct user impact. labels Sep 23, 2020
@maintainer-s-little-helper maintainer-s-little-helper Bot added dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. and removed dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. labels Sep 23, 2020
@christarazi

This comment has been minimized.

Sign in to view
@christarazi
k8s: Remove CRD deleting functionality
36f20cc 
This commit removes the ability to delete CRDs from Cilium because that
would delete all the CRs in the cluster.

Follow-up from:
cilium#11477 (comment)

Updates: cilium#12737

Signed-off-by: Chris Tarazi <chris@isovalent.com>
@christarazi christarazi force-pushed the pr/christarazi/remove-delete-crd branch from 6c4d6ce to 36f20cc Compare September 23, 2020 22:50
@christarazi christarazi requested a review from a team as a code owner September 23, 2020 22:50
@christarazi
Copy link
Copy Markdown
Member Author

christarazi commented Sep 23, 2020 •
edited
Loading

test-me-please

Edit: runtime hit #12862

This was referenced Sep 23, 2020
Closed
Closed
@christarazi
Copy link
Copy Markdown
Member Author

christarazi commented Sep 24, 2020

retest-runtime

@christarazi christarazi added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Sep 24, 2020
@qmonnet qmonnet merged commit 5c6aad6 into cilium:master Sep 24, 2020
@vadorovsky vadorovsky mentioned this pull request Sep 25, 2020
Merged
@vadorovsky vadorovsky mentioned this pull request Sep 25, 2020
Merged
@christarazi christarazi deleted the pr/christarazi/remove-delete-crd branch September 25, 2020 20:57
@joestringer
Copy link
Copy Markdown
Member

joestringer commented Sep 29, 2020

Due to conflicts and the fact this is not a critical bugfix for v1.6, I am removing backport tag for that version.

This was referenced Sep 30, 2020
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aanm aanm aanm approved these changes

+1 more reviewer

@vadorovsky vadorovsky vadorovsky approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area/k8s Impacts the kubernetes API, or kubernetes -> cilium internals translation layers. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@christarazi @joestringer @aanm @vadorovsky @qmonnet