Skip to content

k8s: Remove deprecated identity status field#13053

Merged
nebril merged 1 commit intocilium:masterfrom
christarazi:pr/christarazi/remove-deprecated-identity-status
Sep 7, 2020
Merged

k8s: Remove deprecated identity status field#13053
nebril merged 1 commit intocilium:masterfrom
christarazi:pr/christarazi/remove-deprecated-identity-status

Conversation

@christarazi
Copy link
Copy Markdown
Member

Following the deprecation notice from
#11275, remove the field.

Following the deprecation notice from
cilium#11275, remove the field.

Signed-off-by: Chris Tarazi <chris@isovalent.com>
@christarazi christarazi requested a review from a team as a code owner September 2, 2020 22:06
@christarazi christarazi requested a review from a team September 2, 2020 22:06
@christarazi christarazi requested a review from a team as a code owner September 2, 2020 22:06
@christarazi christarazi added area/k8s Impacts the kubernetes API, or kubernetes -> cilium internals translation layers. kind/cleanup This includes no functional changes. release-note/misc This PR makes changes that have no direct user impact. labels Sep 2, 2020
@maintainer-s-little-helper maintainer-s-little-helper bot added dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. and removed dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. labels Sep 2, 2020
@christarazi
Copy link
Copy Markdown
Member Author

christarazi commented Sep 2, 2020

test-me-please

Edit: net-next hit #13071

Copy link
Copy Markdown
Member

@sayboras sayboras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🥇

Just want to check if any docs (e.g. spec, upgrade note, etc) is required, or this change will be just transparent to users.

@christarazi
Copy link
Copy Markdown
Member Author

LGTM 1st_place_medal

Just want to check if any docs (e.g. spec, upgrade note, etc) is required, or this change will be just transparent to users.

The change should be transparent as the aforementioned PR migrates its usage to be under the purview of CiliumEndpoint. I did a quick scan over the docs and don't see any mention of this field. Thanks for the tip.

@christarazi
Copy link
Copy Markdown
Member Author

retest-net-next

@christarazi
Copy link
Copy Markdown
Member Author

Code owner approval and full CI have passed. Marking ready to merge. (Not sure why maintainer's little helper didn't detect this PR as ready.)

@christarazi christarazi added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Sep 4, 2020
@nebril nebril merged commit cdeb302 into cilium:master Sep 7, 2020
@christarazi christarazi deleted the pr/christarazi/remove-deprecated-identity-status branch September 8, 2020 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/k8s Impacts the kubernetes API, or kubernetes -> cilium internals translation layers. kind/cleanup This includes no functional changes. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants