connectivity-check: Use unprivileged ports#12948
Merged
Conversation
Use of port 80 causes unnecessary requirements for k8s environments to allow pods to bind to privileged ports. Switch to port 8080 instead. Signed-off-by: Thomas Graf <thomas@cilium.io>
Contributor
Author
|
test-me-please |
sayboras
approved these changes
Aug 21, 2020
Member
sayboras
left a comment
There was a problem hiding this comment.
LGTM 💯
Just curious if there is any plan to use unprivileged ports for cilium services as well. If I am not wrong, some hubble related service might still use port 80.
Contributor
Author
|
test-me-please |
joestringer
approved these changes
Aug 21, 2020
Member
I think the Hubble related services you might be referring to (hubble-relay and hubble-ui) are only using port 80 on the service frontend, but not the container (target) port. hubble-relay listens on port 4245, hubble-ui on port 12000. In that case, I don't think we suffer the problem this PR is addressing (which is fixing up the container ports) |
This was referenced Aug 27, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use of port 80 causes unnecessary requirements for k8s environments to
allow pods to bind to privileged ports. Switch to port 8080 instead.