Skip to content

Invoke go-bindata from the vendor directory instead of requiring it explicitly#12805

Merged
aanm merged 4 commits intocilium:masterfrom
christarazi:pr/christarazi/go-bindata-followups
Aug 7, 2020
Merged

Invoke go-bindata from the vendor directory instead of requiring it explicitly#12805
aanm merged 4 commits intocilium:masterfrom
christarazi:pr/christarazi/go-bindata-followups

Conversation

@christarazi
Copy link
Copy Markdown
Member

@christarazi christarazi commented Aug 6, 2020 •
edited
Loading

Updates: #12737
Fixes: #11607

@christarazi
vendor: Add go-bindata CLI
45120ba 
This commit allows us to remove the need for developers to install the
tool itself externally. We can instead run it from the vendor/ path.

Fixes: 052e7a9 ("vendor: Add go-bindata")

Signed-off-by: Chris Tarazi <chris@isovalent.com>
@christarazi
Revert "docs: Update dev requirements with go-bindata"
5660a3e 
This reverts commit 19c0e77.

This commit is no longer needed now that we vendor in the go-bindata CLI
itself.

Signed-off-by: Chris Tarazi <chris@isovalent.com>
@christarazi
Revert ".github: Add go-bindata installation step"
e3e624d 
This reverts commit 5c044e0.

This commit is no longer needed now that we vendor in the go-bindata CLI
itself.

Signed-off-by: Chris Tarazi <chris@isovalent.com>
@christarazi
Makefile: Run go-bindata from vendor directory
328c5f3 
This commit follows up on the additional vendoring of the go-bindata
CLI. Previously, we required the user to have the CLI installed
externally.

This commit also adds the changes that were made when invoking this
target.

Signed-off-by: Chris Tarazi <chris@isovalent.com>
@christarazi christarazi requested review from a team as code owners August 6, 2020 19:14
@christarazi christarazi added kind/cleanup This includes no functional changes. release-note/misc This PR makes changes that have no direct user impact. labels Aug 6, 2020
@maintainer-s-little-helper maintainer-s-little-helper Bot added dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. and removed dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. labels Aug 6, 2020
@christarazi christarazi requested a review from aanm August 6, 2020 19:14
@christarazi
Copy link
Copy Markdown
Member Author

christarazi commented Aug 6, 2020

test-me-please

@aanm aanm mentioned this pull request Aug 6, 2020
Closed
12 tasks
@coveralls
Copy link
Copy Markdown

coveralls commented Aug 6, 2020

Coverage Status

Coverage decreased (-0.003%) to 37.116% when pulling 328c5f3 on christarazi:pr/christarazi/go-bindata-followups into 3996e5a on cilium:master.

@aanm aanm merged commit a8c8861 into cilium:master Aug 7, 2020
@christarazi christarazi deleted the pr/christarazi/go-bindata-followups branch August 8, 2020 01:24
@joestringer joestringer mentioned this pull request Oct 12, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joestringer joestringer joestringer approved these changes

@aanm aanm aanm approved these changes

Assignees

No one assigned

Labels

kind/cleanup This includes no functional changes. release-note/misc This PR makes changes that have no direct user impact.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@christarazi @coveralls @joestringer @aanm